[build_script.py] Add --foundation-build-dir parameter [AsyncXCTest 1/6] #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiftlang#43 will add a dependency between swift-corelibs-xctest and swift-corelibs-foundation. This will also necessitate the build script to take a '--foundation-build-dir' parameter. However, the Swift CI does not yet supply this parameter. To prevent CI from breaking when swiftlang#43 is landed, preemptively add the '--foundation-build-dir' parameter. Before landing swiftlang#43, the Swift build script will be modified to pass this parameter to the XCTest build script.
Contributor
Author
|
Here's how the build script will need to change: modocache/swift@71f20f6 Notice that it passes '--foundation-build-dir' to the XCTest build script. |
4 tasks
Contributor
|
LGTM! |
modocache
changed the title
modocache
changed the title
|
@swift-ci please test |
|
case-sensitively... @swift-ci Please test |
|
@swift-ci Please test |
Contributor
Author
|
Merging. OS X is a known failure for now. I believe work's being done for |
modocache
added a commit
that referenced
this pull request
Mar 8, 2016
…migration [build_script.py] Add --foundation-build-dir parameter [AsyncXCTest 1/6]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#43 will add a dependency between swift-corelibs-xctest and swift-corelibs-foundation. This will also necessitate the build script to take a '--foundation-build-dir' parameter. However, the Swift CI does not yet supply this parameter.
To prevent CI from breaking when #43 is landed, preemptively add the '--foundation-build-dir' parameter. Before landing #43, the Swift build script will be modified to pass this parameter to the XCTest build script.