Master merge for #915 #916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@swift-ci please test |
Member
|
I am wondering if we should have a test case for this bug fix. I'll check if the |
Member
|
@swizzlr It will be great if we can have a test on these lines (feel free to use this code, if needed): |
Member
|
@swift-ci please test |
Member
|
Unrelated failure. Let me try one more time. @swift-ci please test |
Member
|
Same compiler crash again. May be we should wait? |
Contributor
Author
|
@pushkarnk Well, this crash doesn't have anything to do with this PR, right? |
Member
|
Yes, but it can't be merged without the CI tests passing :( Let me try again. @swift-ci please test and merge |
Member
|
@swift-ci please test and merge |
Contributor
Author
|
Compiler engineers, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#915