Instead of crashing with unknown types in print, use description #5207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test |
iCharlesHu
approved these changes
Jun 4, 2025
Contributor
Author
|
@swift-ci test |
parkera
force-pushed
the
parkera/allow_other_types_in_print
branch
from
097823b to
dd9c594
Compare
Contributor
Author
|
@swift-ci test |
1 similar comment
Contributor
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Darwin,
plutil -pcan print keyed archiver archives. They containUUID, which is a not a property list type, soplutilspecial cases them for ease of use.Instead of throwing when we hit an unknown type, simply print a description - which is basically what the Objective-C implementation used to do.