Align __NSCFType with CFRuntimeBase / _CFInfo #1694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__NSCFType has been using Int32 for _cfinfo. More recently in Swift 4, it’s been noticed that this can cause problems on 32-bit ARM and should be aligned with _CFInfo instead.
Contributor
Author
parkera
approved these changes
Sep 13, 2018
Contributor
|
@swift-ci test |
Member
|
@swift-ci test macOS |
Contributor
|
@shahmishal Looking at the CI logs @ https://ci.swift.org/job/swift-corelibs-foundation-PR-macOS/2/console for the macOS testing, I cant see it actually running the tests for Foundation, although it is building Foundation. Is this as expected? |
Contributor
Author
|
@spevans I'm curious about that too. |
Member
|
Seems that this is ready to go, and already approved by @parkera |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__NSCFType has been using Int32 for _cfinfo. More recently in Swift 4, it’s been noticed that this can cause problems on 32-bit ARM and should be aligned with _CFInfo instead.
Currently, there are no known issues on 32-bit ARM because of this. However, it'd be nice to fix this before some future change breaks because _cfinfo is an Int32.