SR-936: NSMutableData.hash() causes a segmentation fault on Linux #1669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CFHash() doesnt see objects of type NSMutableData as CF objects so calls back to NSObject.hash which causes infinite recursion. - Directly call _CFNonObjCHash() to bypass this check.
Contributor
Author
|
@swift-ci please test |
Contributor
|
Yikes. This would be good for the 4.2 branch. |
parkera
approved these changes
Aug 27, 2018
Contributor
Author
|
@parkera Would this affect other classes? Should |
Contributor
|
That is reasonable. It looks like most of our Darwin ObjC implementations simply implement their own hash instead of using the CFHash function in the first place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CFHash() doesnt see objects of type NSMutableData as CF objects
so calls back to NSObject.hash which causes infinite recursion.
Directly call _CFNonObjCHash() to bypass this check.