SR-7017: JSONDecoder will decode booleans as numbers. #1442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If an NSNumber was initialised from a boolean then dont allow it to be converted to a numeric value.
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test |
itaiferber
suggested changes
Feb 19, 2018
Contributor
itaiferber
left a comment
itaiferber
left a comment
There was a problem hiding this comment.
Thanks for putting this together! The approach is sound, but do you think we'd be able to get the source changes here closer to what was done in swiftlang/swift#11885? The less our implementations and tests diverge between the overlay and swift-corelibs-foundation, the easier it'll be to to apply similar changes between them.
Contributor
Author
|
@itaiferber Ive updated it to match the overlay. |
Contributor
Author
|
@swift-ci please test |
3 similar comments
Contributor
Author
|
@swift-ci please test |
Contributor
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test |
Contributor
|
@itaiferber can you re-review the changes after Simon added the subsequent commit? It looks like the tests pass now. |
Contributor
|
@alblue Yes, sorry — this fell off my Radar. |
itaiferber
approved these changes
Feb 22, 2018
Contributor
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be converted to a numeric value.
Tested against native Darwin Foundation.