Skip to content

Change NSURLRequest's HTTPMethod property stub to be readonly #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Change NSURLRequest's HTTPMethod property stub to be readonly #13

wants to merge 2 commits into from

Conversation

@angelodipaolo
Copy link
Contributor

@angelodipaolo angelodipaolo commented Dec 3, 2015

  • Add several of NSURLRequest's properties as stubs
  • Change NSURLRequest's HTTPMethod property stub to be readonly
  • Add mutable property stub to NSMutableURLRequest

@parkera
Copy link
Contributor

parkera commented Dec 3, 2015

I want to merge ed31a34 (thanks for catching that), but the other one I have a few comments on. We made a conscious decision to leave off those particular properties and replace them with using the properties on NSURLSessionConfiguration.

@angelodipaolo
Copy link
Contributor Author

angelodipaolo commented Dec 3, 2015

Thanks for the information. Using NSURLSessionConfiguration makes sense for those properties. I'm closing this PR in favor of #14 which has the ed31a34 cherry picked.

atrick pushed a commit to atrick/swift-corelibs-foundation that referenced this pull request Jan 12, 2021
@akyrtzi
Merge pull request swiftlang#13 from akyrtzi/toolchain-unknown-linux
4b89b6d 
[SKCore] If 'Platform.currentPlatform' is nil use 'so' as library extension
kateinoigakukun pushed a commit to kateinoigakukun/swift-corelibs-foundation that referenced this pull request Apr 29, 2021
@aciidgh
Merge pull request swiftlang#13 from apple/remove-swift-update-test
decef53 
Remove swift package update test
@swift-ci swift-ci mentioned this pull request Apr 25, 2022
Open
@davezarzycki davezarzycki mentioned this pull request May 5, 2022
Open
@swift-ci swift-ci mentioned this pull request May 5, 2022
Closed
kateinoigakukun pushed a commit to kateinoigakukun/swift-corelibs-foundation that referenced this pull request Oct 11, 2023
@pull
Merge pull request swiftlang#13 from swiftwasm/master
925fe85 
[pull] swiftwasm from master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@angelodipaolo @parkera