NSString.init?(data: encoding:) implemented

Author: bubski

Foundation/NSString.swift

@@ -694,7 +694,7 @@ extension NSString {
     }
 
     public convenience init?(data: NSData, encoding: UInt) {
-        NSUnimplemented()    
+        self.init(bytes: data.bytes, length: data.length, encoding: encoding)
     }
 
     public convenience init?(bytes: UnsafePointer<Void>, length len: Int, encoding: UInt) {

TestFoundation/TestNSString.swift

@@ -26,6 +26,9 @@ class TestNSString : XCTestCase {
             ("test_FromASCIIData", test_FromASCIIData ),
             ("test_FromUTF8Data", test_FromUTF8Data ),
             ("test_FromMalformedUTF8Data", test_FromMalformedUTF8Data ),
+            ("test_FromASCIINSData", test_FromASCIINSData ),
+            ("test_FromUTF8NSData", test_FromUTF8NSData ),
+            ("test_FromMalformedUTF8NSData", test_FromMalformedUTF8NSData ),
         ]
     }
 
@@ -71,4 +74,27 @@ class TestNSString : XCTestCase {
         let string = NSString(bytes: bytes, length: bytes.count, encoding: NSUTF8StringEncoding)
         XCTAssertNil(string)
     }
+
+    func test_FromASCIINSData() {
+        let bytes: [UInt8] = [0x48, 0x65, 0x6C, 0x6C, 0x6F, 0x20, 0x53, 0x77, 0x69, 0x66, 0x74, 0x21] // "Hello Swift!"
+        let data = NSData(bytes: bytes, length: bytes.count)
+        let string = NSString(data: data, encoding: NSASCIIStringEncoding)
+        XCTAssertNotNil(string)
+        XCTAssertTrue(string!.isEqualToString("Hello Swift!"))
+    }
+
+    func test_FromUTF8NSData() {
+        let bytes: [UInt8] = [0x49, 0x20, 0xE2, 0x9D, 0xA4, 0xEF, 0xB8, 0x8F, 0x20, 0x53, 0x77, 0x69, 0x66, 0x74] // "I ❤️ Swift"
+        let data = NSData(bytes: bytes, length: bytes.count)
+        let string = NSString(data: data, encoding: NSUTF8StringEncoding)
+        XCTAssertNotNil(string)
+        XCTAssertTrue(string?.isEqualToString("I ❤️ Swift") ?? false)
+    }
+
+    func test_FromMalformedUTF8NSData() {
+        let bytes: [UInt8] = [0xFF]
+        let data = NSData(bytes: bytes, length: bytes.count)
+        let string = NSString(data: data, encoding: NSUTF8StringEncoding)
+        XCTAssertNil(string)
+    }
 }