Merge pull request #2638 from spevans/pr_minor_warnings

Author: swift-ci

Foundation/Decimal.swift

@@ -101,7 +101,7 @@ extension Decimal {
 public func pow(_ x: Decimal, _ y: Int) -> Decimal {
     var x = x
     var result = Decimal()
-    NSDecimalPower(&result, &x, y, .plain)
+    _ = NSDecimalPower(&result, &x, y, .plain)
     return result
 }
 

Foundation/NSCFCharacterSet.swift

@@ -43,7 +43,7 @@ internal class _NSCFCharacterSet : NSMutableCharacterSet {
     }
 
     override func copy(with zone: NSZone? = nil) -> Any {
-        return CFCharacterSetCreateCopy(kCFAllocatorSystemDefault, self._cfObject)
+        return CFCharacterSetCreateCopy(kCFAllocatorSystemDefault, self._cfObject) as Any
     }
 
     override func mutableCopy(with zone: NSZone? = nil) -> Any {

Foundation/NSCharacterSet.swift

@@ -370,7 +370,7 @@ open class NSCharacterSet : NSObject, NSCopying, NSMutableCopying, NSSecureCodin
         if type(of: self) == NSCharacterSet.self || type(of: self) == NSMutableCharacterSet.self {
             return _CFCharacterSetCreateCopy(kCFAllocatorSystemDefault, self._cfObject)
         } else if type(of: self) == _NSCFCharacterSet.self {
-            return CFCharacterSetCreateCopy(kCFAllocatorSystemDefault, self._cfObject)
+            return CFCharacterSetCreateCopy(kCFAllocatorSystemDefault, self._cfObject) as Any
         } else {
             NSRequiresConcreteImplementation()
         }

Foundation/NSKeyedArchiver.swift

@@ -223,8 +223,8 @@ open class NSKeyedArchiver : NSCoder {
                 success = true
             }
         } else {
-            success = CFPropertyListWrite(plist, self._stream as! CFWriteStream,
-                                          kCFPropertyListXMLFormat_v1_0, 0, nil) > 0
+            let stream = self._stream as! CFWriteStream
+            success = CFPropertyListWrite(plist, stream, kCFPropertyListXMLFormat_v1_0, 0, nil) > 0
         }
 
         return success

Foundation/NSObject.swift

@@ -370,7 +370,7 @@ open class NSObject : NSObjectProtocol, Equatable, Hashable {
         // On Darwin, avoids dipping into the class hierarchy that exists above this class,
         // which is ultimately rooted in the ObjC NSObject class.
         guard !(self == NSObject.self) else { return nil }
-        return _getSuperclass(self) as! NSObject.Type
+        return _getSuperclass(self) as? NSObject.Type
     }
 
     public class var superclass: AnyClass? {

Foundation/NumberFormatter.swift

@@ -283,7 +283,7 @@ open class NumberFormatter : Formatter {
 
     private func defaultFormatWidth() -> Int {
         switch numberStyle {
-        case .ordinal, .ordinal, .spellOut, .currencyPlural:
+        case .ordinal, .spellOut, .currencyPlural:
             return 0
 
         case .none, .decimal, .currency, .percent, .scientific, .currencyISOCode, .currencyAccounting:

Foundation/URLResponse.swift

@@ -356,7 +356,7 @@ private func getSuggestedFilename(fromHeaderFields headerFields: [String : Strin
         else { return nil }
     for part in field.parameters where part.attribute == "filename" {
         if let path = part.value {
-            return (path as? NSString)?.pathComponents.map{ $0 == "/" ? "" : $0}.joined(separator: "_")
+            return (path as NSString).pathComponents.map{ $0 == "/" ? "" : $0}.joined(separator: "_")
         } else {
             return nil
         }

Foundation/URLSession/FoundationNetworking-Info.plist

@@ -7,7 +7,7 @@
 	<key>CFBundleExecutable</key>
 	<string>SwiftFoundation</string>
 	<key>CFBundleIdentifier</key>
-	<string>org.swift.Foundation</string>
+	<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>