Fix UserDefaults.float(forKey:) behavior

Author: woxtu

Sources/Foundation/UserDefaults.swift

@@ -213,6 +213,15 @@ open class UserDefaults: NSObject {
         if let bVal = aVal as? Float {
             return bVal
         }
+        if let bVal = aVal as? Bool {
+            return NSNumber(value: bVal).floatValue
+        }
+        if let bVal = aVal as? Int {
+            return NSNumber(value: bVal).floatValue
+        }
+        if let bVal = aVal as? Double {
+            return NSNumber(value: bVal).floatValue
+        }
         if let bVal = aVal as? String {
             return NSString(string: bVal).floatValue
         }

Tests/Foundation/Tests/TestUserDefaults.swift

@@ -32,6 +32,10 @@ class TestUserDefaults : XCTestCase {
 			("test_setValue_IntFromFloat", test_setValue_IntFromFloat ),
 			("test_setValue_IntFromDouble", test_setValue_IntFromDouble ),
 			("test_setValue_IntFromString", test_setValue_IntFromString ),
+			("test_setValue_FloatFromBool", test_setValue_FloatFromBool ),
+			("test_setValue_FloatFromInt", test_setValue_FloatFromInt ),
+			("test_setValue_FloatFromDouble", test_setValue_FloatFromDouble ),
+			("test_setValue_FloatFromString", test_setValue_FloatFromString ),
 			("test_setValue_DoubleFromString", test_setValue_DoubleFromString ),
 			("test_setValue_StringFromBool", test_setValue_StringFromBool ),
 			("test_setValue_StringFromInt", test_setValue_StringFromInt ),
@@ -270,6 +274,42 @@ class TestUserDefaults : XCTestCase {
 		XCTAssertEqual(defaults.integer(forKey: "key1"), 1234)
 	}
 
+	func test_setValue_FloatFromBool() {
+		let defaults = UserDefaults.standard
+
+		// Register a boolean default value. UserDefaults.float(forKey:) is supposed to return the converted Float value
+		defaults.set(true, forKey: "key1")
+
+		XCTAssertEqual(defaults.float(forKey: "key1"), 1)
+	}
+
+	func test_setValue_FloatFromInt() {
+		let defaults = UserDefaults.standard
+
+		// Register an integer default value. UserDefaults.float(forKey:) is supposed to return the converted Float value
+		defaults.set(42, forKey: "key1")
+
+		XCTAssertEqual(defaults.float(forKey: "key1"), 42)
+	}
+
+	func test_setValue_FloatFromDouble() {
+		let defaults = UserDefaults.standard
+
+		// Register a double default value. UserDefaults.float(forKey:) is supposed to return the converted Float value
+		defaults.set(12.34, forKey: "key1")
+
+		XCTAssertEqual(defaults.float(forKey: "key1"), 12.34)
+	}
+
+	func test_setValue_FloatFromString() {
+		let defaults = UserDefaults.standard
+
+		// Register a string default value. UserDefaults.float(forKey:) is supposed to return the parsed Float value
+		defaults.set("1234", forKey: "key1")
+
+		XCTAssertEqual(defaults.float(forKey: "key1"), 1234)
+	}
+
 	func test_setValue_DoubleFromString() {
 		let defaults = UserDefaults.standard