Merge pull request #2821 from Molanda/implement_string_varargs

Added CVarArg support to NSString and String

Author: millenomi

Sources/Foundation/NSString.swift

@@ -1644,3 +1644,24 @@ extension NSString : _StructTypeBridgeable {
         return _StructType._unconditionallyBridgeFromObjectiveC(self)
     }
 }
+
+extension NSString : CVarArg {
+    @inlinable // c-abi
+    public var _cVarArgEncoding: [Int] {
+        return _encodeBitsAsWords(unsafeBitCast(self, to: AnyObject.self))
+    }
+}
+
+#if !_runtime(_ObjC)
+extension String : CVarArg, _CVarArgObject {
+    @inlinable // c-abi
+    public var _cVarArgObject: CVarArg {
+        return NSString(string: self)
+    }
+
+    @inlinable // c-abi
+    public var _cVarArgEncoding: [Int] {
+        fatalError("_cVarArgEncoding must be called on NSString instead")
+    }
+}
+#endif

Tests/Foundation/Tests/TestNSString.swift

@@ -813,6 +813,15 @@ class TestNSString: LoopbackServerTest {
         }
     }
 
+    func test_initializeWithFormat4() {
+        let argument: [CVarArg] = ["One", "Two", "Three"]
+        withVaList(argument) {
+            pointer in
+            let string = NSString(format: "Testing %@ %@ %@", arguments: pointer)
+            XCTAssertEqual(string, "Testing One Two Three")
+        }
+    }
+
     func test_appendingPathComponent() {
         do {
             let path: NSString = "/tmp"
@@ -1677,6 +1686,7 @@ class TestNSString: LoopbackServerTest {
             ("test_initializeWithFormat", test_initializeWithFormat),
             ("test_initializeWithFormat2", test_initializeWithFormat2),
             ("test_initializeWithFormat3", test_initializeWithFormat3),
+            ("test_initializeWithFormat4", test_initializeWithFormat4),
             ("test_appendingPathComponent", test_appendingPathComponent),
             ("test_deletingLastPathComponent", test_deletingLastPathComponent),
             ("test_getCString_simple", test_getCString_simple),