FileManager: repair homeDirectoryForCurrentUser on Windows

compnerd · compnerd · commit 0b95e12180d7 · 2023-01-20T14:06:20.000-08:00
The `homeDirectory(forUser:)` is currently not functioning properly for
users other than the current user.  Switch to directly using the
CoreFoundation API which simplifies the logic and makes the
functionality work on Windows.  This uses the forced unwrap for the
return value, which was previously the case and resulted in a trap on
Windows.
diff --git a/Sources/Foundation/FileManager.swift b/Sources/Foundation/FileManager.swift
@@ -1140,7 +1140,7 @@ open class FileManager : NSObject {
     }
 
     open var homeDirectoryForCurrentUser: URL {
-        return homeDirectory(forUser: NSUserName())!
+        CFCopyHomeDirectoryURLForUser(nil)!.takeRetainedValue()._swiftObject
     }
     
     open var temporaryDirectory: URL {

Original file line number	Diff line number	Diff line change
`@@ -1140,7 +1140,7 @@ open class FileManager : NSObject {`
`1140`	`1140`	`}`
`1141`	`1141`
`1142`	`1142`	`open var homeDirectoryForCurrentUser: URL {`
`1143`		`- return homeDirectory(forUser: NSUserName())!`
	`1143`	`+ CFCopyHomeDirectoryURLForUser(nil)!.takeRetainedValue()._swiftObject`
`1144`	`1144`	`}`
`1145`	`1145`
`1146`	`1146`	`open var temporaryDirectory: URL {`