CMake: Fix SwiftCrypto/SwiftASN1 order #2194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwiftCrypto requires SwiftASN1. SwiftCrypto should be declaring the dependency in its import files, but is not currently doing so resulting in `find_package(SwiftCrypto)` failing because the `SwiftASN1` target does not yet exist. By placing `find_package(SwiftASN1)` before finding SwiftCrypto, we ensure that the `SwiftASN1` target is populated ahead of time and finding SwiftCrypto succeeds.
etcwilde
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
Member
Author
|
CC @compnerd |
Member
Author
|
@swift-ci please test |
compnerd
approved these changes
Jul 3, 2025
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
This should be safe to go in before the swift-crypto change right?
Member
Author
Yes, this is so that the swift-crypto change isn't needed and I don't have to wait for a new crypto tag to bump the package versions. Once SourceKit-LSP depends on a version that is at least as new as that change, we should be able to drop the |
bnbarham
approved these changes
Jul 3, 2025
Member
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwiftCrypto requires SwiftASN1. SwiftCrypto should be declaring the dependency in its import files, but is not currently doing so resulting in
find_package(SwiftCrypto)failing because theSwiftASN1target does not yet exist.By placing
find_package(SwiftASN1)before finding SwiftCrypto, we ensure that theSwiftASN1target is populated ahead of time and finding SwiftCrypto succeeds.The fix to the missing dependency is posted for review: apple/swift-crypto#376.
This change is to allow building SourceKit-LSP without needing a new tag on swift-crypto.