From 3100007dc919f4b9789c641d3375e168dba4262b Mon Sep 17 00:00:00 2001 From: Rintaro Ishizaki Date: Mon, 1 Apr 2024 09:32:26 -0700 Subject: [PATCH 1/2] [lldb] Disable TestSwiftImageLookupPC.py This test is failing in CentOS bot rdar://125497260 --- .../API/commands/target/modules/swift/TestSwiftImageLookupPC.py | 1 + 1 file changed, 1 insertion(+) diff --git a/lldb/test/API/commands/target/modules/swift/TestSwiftImageLookupPC.py b/lldb/test/API/commands/target/modules/swift/TestSwiftImageLookupPC.py index 577088e9c1890..5ef671444a7e5 100644 --- a/lldb/test/API/commands/target/modules/swift/TestSwiftImageLookupPC.py +++ b/lldb/test/API/commands/target/modules/swift/TestSwiftImageLookupPC.py @@ -7,6 +7,7 @@ class SwiftAddressExpressionTest(TestBase): @swiftTest + @skipIfLinux # rdar://125497260 def test(self): """Test that you can use register names in image lookup in a swift frame.""" self.build() From 58c7a1104008feb5f49eeb9397c53ace7e197ea6 Mon Sep 17 00:00:00 2001 From: Rintaro Ishizaki Date: Tue, 2 Apr 2024 15:52:05 -0700 Subject: [PATCH 2/2] Revert "Try to figure out why this test is failing on CentOS and no other Linux." This reverts commit 74ed35ab0014b5e3186831a412c9127362127a16. --- .../modules/swift/TestSwiftImageLookupPC.py | 22 +------------------ 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/lldb/test/API/commands/target/modules/swift/TestSwiftImageLookupPC.py b/lldb/test/API/commands/target/modules/swift/TestSwiftImageLookupPC.py index 5ef671444a7e5..595f3daf6520d 100644 --- a/lldb/test/API/commands/target/modules/swift/TestSwiftImageLookupPC.py +++ b/lldb/test/API/commands/target/modules/swift/TestSwiftImageLookupPC.py @@ -12,29 +12,9 @@ def test(self): """Test that you can use register names in image lookup in a swift frame.""" self.build() (target, process, thread, breakpoint) = lldbutil.run_to_source_breakpoint(self, - "break here to check image lookup", lldb.SBFileSpec("main.swift")) + "break here to check image lookup", lldb.SBFileSpec("main.swift")) # I don't want to be too specific in what we print for image lookup, # we're testing that the address expression for the pc worked. self.expect("image lookup -va $pc", substrs=["doSomething"]) self.expect("image lookup -va $pc+4", substrs=["doSomething"]) - - def test_using_alias(self): - """Test that you can use register names in image lookup in a swift frame.""" - self.build() - (target, process, thread, breakpoint) = lldbutil.run_to_source_breakpoint(self, - "break here to check image lookup", lldb.SBFileSpec("main.swift")) - # I don't want to be too specific in what we print for image lookup, - # we're testing that the address expression for the pc worked. - self.expect("target modules lookup -va $pc", substrs=["doSomething"]) - self.expect("target modules lookup -va $pc+4", substrs=["doSomething"]) - - def test_using_separate_options(self): - """Test that you can use register names in image lookup in a swift frame.""" - self.build() - (target, process, thread, breakpoint) = lldbutil.run_to_source_breakpoint(self, - "break here to check image lookup", lldb.SBFileSpec("main.swift")) - # I don't want to be too specific in what we print for image lookup, - # we're testing that the address expression for the pc worked. - self.expect("target modules lookup -v -a $pc", substrs=["doSomething"]) - self.expect("target modules lookup -v -a $pc+4", substrs=["doSomething"])