From 9e35e05116c63c38d8cb2c315017112cdc0141b3 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 10 Sep 2025 17:23:17 +0100 Subject: [PATCH 1/2] [lldb][test] Re-enable `TestRerunAndExprDylib.py` (#157872) the `skipTestIfFn` requires a function that return a string to skip or None to run the test. The `isUbuntu18_04` function returns a bool and the test is skipped on all platforms. https://github.com/llvm/llvm-project/blob/25ebdfe0ab202a6cb30232d84bc5838439fd67d5/lldb/packages/Python/lldbsuite/test/decorators.py#L145-L157 (cherry picked from commit f5315bd135b6e65ebfb0d27f6333501c3a4b32b3) --- .../rerun_and_expr_dylib/TestRerunAndExprDylib.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lldb/test/API/functionalities/rerun_and_expr_dylib/TestRerunAndExprDylib.py b/lldb/test/API/functionalities/rerun_and_expr_dylib/TestRerunAndExprDylib.py index 74e7c895c0fab..a8f98ef0f0182 100644 --- a/lldb/test/API/functionalities/rerun_and_expr_dylib/TestRerunAndExprDylib.py +++ b/lldb/test/API/functionalities/rerun_and_expr_dylib/TestRerunAndExprDylib.py @@ -20,9 +20,9 @@ def isUbuntu18_04(): with open(path) as f: contents = f.read() if "Ubuntu 18.04" in contents: - return True + return "Ubuntu 18.04 is not supported." - return False + return None class TestRerunExprDylib(TestBase): From 9f062ad6d108e498665f0d76ca1d06524d7086cf Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 10 Sep 2025 20:26:36 +0100 Subject: [PATCH 2/2] [lldb][test] skip test `TestRerunAndExprDylib.py` on remote (#157916) (cherry picked from commit 55e99efdf1bdd7150f680eee171e0d867a0864c6) --- .../rerun_and_expr_dylib/TestRerunAndExprDylib.py | 1 + 1 file changed, 1 insertion(+) diff --git a/lldb/test/API/functionalities/rerun_and_expr_dylib/TestRerunAndExprDylib.py b/lldb/test/API/functionalities/rerun_and_expr_dylib/TestRerunAndExprDylib.py index a8f98ef0f0182..19edaac964e62 100644 --- a/lldb/test/API/functionalities/rerun_and_expr_dylib/TestRerunAndExprDylib.py +++ b/lldb/test/API/functionalities/rerun_and_expr_dylib/TestRerunAndExprDylib.py @@ -28,6 +28,7 @@ def isUbuntu18_04(): class TestRerunExprDylib(TestBase): @skipTestIfFn(isUbuntu18_04, bugnumber="rdar://103831050") @skipIfWindows + @skipIfRemote def test(self): """ Tests whether re-launching a process without destroying