Skip to content

[BoundsSafety][NFC] Revert "Revert "Fix bounds safty tests."" #10140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

delcypher
Copy link

This reverts commit 07f057b.

In upstream this landed

commit e56a6a2683a82b21d47a5b881fb4eb104c5d8e0a
error: cannot run gpg: No such file or directory
Author: Nikita Popov <[email protected]>
Date:   Thu Feb 27 09:38:29 2025 +0100

    Reapply [CaptureTracking][FunctionAttrs] Add support for CaptureInfo (#125880) (#128020)

which is another attempt at landing llvm#125880.

The -fbounds-safety tests were already adjusted when this was landed before but we had to revert these changes when upstream reverted $125880.

So now this PR reverts the revert of the test changes.

Hopefully the upstream PR doesn't get reverted again.

rdar://145796299

This reverts commit 07f057b.

In upstream this landed

```
commit e56a6a2
error: cannot run gpg: No such file or directory
Author: Nikita Popov <[email protected]>
Date:   Thu Feb 27 09:38:29 2025 +0100

    Reapply [CaptureTracking][FunctionAttrs] Add support for CaptureInfo (llvm#125880) (llvm#128020)
```

which is another attempt at landing llvm#125880.

The `-fbounds-safety` tests were already adjusted when this was landed
before but we had to revert these changes when upstream reverted $125880.

So now this PR reverts the revert of the test changes.

Hopefully the upstream PR doesn't get reverted again.

rdar://145796299
@delcypher delcypher added the clang:bounds-safety Issue relating to the experimental -fbounds-safety feature in Clang label Feb 28, 2025
@delcypher delcypher self-assigned this Feb 28, 2025
@delcypher delcypher merged commit 8629b17 into next Feb 28, 2025
@delcypher delcypher deleted the dliew/rdar-145796299 branch February 28, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:bounds-safety Issue relating to the experimental -fbounds-safety feature in Clang
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant