[clang/CompileJobCache] Fix UBSan issue

akyrtzi · akyrtzi · commit f7cd52aca92f · 2023-08-25T11:40:07.000-07:00
diff --git a/clang/lib/Frontend/CompileJobCache.cpp b/clang/lib/Frontend/CompileJobCache.cpp
@@ -87,7 +87,8 @@ class ObjectStoreCachingOutputs : public CompileJobCache::CachingOutputs {
                        UseCASBackend),
         ComputedJobNeedsReplay(WriteOutputAsCASID || UseCASBackend),
         MCOutputID(MCOutputID), CAS(std::move(DB)), Cache(std::move(Cache)) {
-    CASOutputs = llvm::makeIntrusiveRefCnt<llvm::cas::CASOutputBackend>(*CAS);
+    if (CAS)
+      CASOutputs = llvm::makeIntrusiveRefCnt<llvm::cas::CASOutputBackend>(*CAS);
   }
 
   Expected<std::optional<int>>

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,8 @@ class ObjectStoreCachingOutputs : public CompileJobCache::CachingOutputs {`
`87`	`87`	`UseCASBackend),`
`88`	`88`	`ComputedJobNeedsReplay(WriteOutputAsCASID \|\| UseCASBackend),`
`89`	`89`	`MCOutputID(MCOutputID), CAS(std::move(DB)), Cache(std::move(Cache)) {`
`90`		`- CASOutputs = llvm::makeIntrusiveRefCnt<llvm::cas::CASOutputBackend>(*CAS);`
	`90`	`+ if (CAS)`
	`91`	`+ CASOutputs = llvm::makeIntrusiveRefCnt<llvm::cas::CASOutputBackend>(*CAS);`
`91`	`92`	`}`
`92`	`93`
`93`	`94`	`Expected<std::optional<int>>`