[lldb] Enable auto-detection of Swift/C++ interop

rdar://97610458

Author: augusto2112

lldb/include/lldb/Core/Module.h

@@ -849,6 +849,8 @@ class Module : public std::enable_shared_from_this<Module>,
   void
   ReportWarningToolchainMismatch(CompileUnit &comp_unit,
                                  llvm::Optional<lldb::user_id_t> debugger_id);
+
+  bool IsSwiftCxxInteropEnabled();
 #endif
 
   // Return true if the file backing this module has changed since the module
@@ -1174,6 +1176,10 @@ class Module : public std::enable_shared_from_this<Module>,
 
   Module(const Module &) = delete;
   const Module &operator=(const Module &) = delete;
+
+#ifdef LLDB_ENABLE_SWIFT
+  LazyBool m_is_swift_cxx_interop_enabled = eLazyBoolCalculate;
+#endif
 };
 
 } // namespace lldb_private

lldb/include/lldb/Target/Target.h

@@ -182,7 +182,7 @@ class TargetProperties : public Properties {
 
   bool GetSwiftEnableBareSlashRegex() const;
 
-  bool GetSwiftEnableCxxInterop() const;
+  EnableSwiftCxxInterop GetEnableSwiftCxxInterop() const;
 
   bool GetSwiftAutoImportFrameworks() const;
 
@@ -1260,6 +1260,7 @@ class Target : public std::enable_shared_from_this<Target>,
   /// Return whether this is the Swift REPL.
   bool IsSwiftREPL();
 
+  bool IsSwiftCxxInteropEnabled();
 private:
   void DisplayFallbackSwiftContextErrors(
       SwiftASTContextForExpressions *swift_ast_ctx);
@@ -1736,6 +1737,11 @@ class Target : public std::enable_shared_from_this<Target>,
 
   Target(const Target &) = delete;
   const Target &operator=(const Target &) = delete;
+
+#ifdef LLDB_ENABLE_SWIFT
+  LazyBool m_is_swift_cxx_interop_enabled = eLazyBoolCalculate;
+#endif // LLDB_ENABLE_SWIFT
+
 };
 
 } // namespace lldb_private

lldb/include/lldb/lldb-private-enumerations.h

@@ -170,6 +170,14 @@ typedef enum SwiftModuleLoadingMode {
   eSwiftModuleLoadingModeOnlyInterface,    // Load via .swiftinterface only
 } SwiftModuleLoadingMode;
 
+// BEGIN SWIFT
+enum EnableSwiftCxxInterop {
+  eAutoDetectSwiftCxxInterop,
+  eEnableSwiftCxxInterop,
+  eDisableSwiftCxxInterop
+};
+// END SWIFT
+
 // Loading modules from memory
 enum MemoryModuleLoadLevel {
   eMemoryModuleLoadLevelMinimal,  // Load sections only

lldb/source/Core/Module.cpp

@@ -1202,6 +1202,48 @@ void Module::ReportWarningToolchainMismatch(
     }
   }
 }
+
+bool Module::IsSwiftCxxInteropEnabled() {
+  switch (m_is_swift_cxx_interop_enabled) {
+  case eLazyBoolYes:
+    return true;
+  case eLazyBoolNo:
+    return false;
+  case eLazyBoolCalculate:
+    break;
+  }
+  EnableSwiftCxxInterop interop_enabled =
+      Target::GetGlobalProperties().GetEnableSwiftCxxInterop();
+  switch (interop_enabled) {
+  case eEnableSwiftCxxInterop:
+    m_is_swift_cxx_interop_enabled = eLazyBoolYes;
+    break;
+  case eDisableSwiftCxxInterop:
+    m_is_swift_cxx_interop_enabled = eLazyBoolNo;
+    break;
+  case eAutoDetectSwiftCxxInterop: {
+    // Look for the "-enable-experimental-cxx-interop" compile flag in the args
+    // of the compile units this module is composed of.
+    auto *sym_file = GetSymbolFile();
+    if (sym_file) {
+      auto options = sym_file->GetCompileOptions();
+      for (auto &[_, args] : options) {
+        for (const char *arg : args.GetArgumentArrayRef()) {
+          if (strcmp(arg, "-enable-experimental-cxx-interop") == 0) {
+            m_is_swift_cxx_interop_enabled = eLazyBoolYes;
+            break;
+          }
+        }
+        if (m_is_swift_cxx_interop_enabled == eLazyBoolYes)
+          break;
+      }
+    }
+    if (m_is_swift_cxx_interop_enabled == eLazyBoolCalculate)
+      m_is_swift_cxx_interop_enabled = eLazyBoolNo;
+  }
+  }
+  return m_is_swift_cxx_interop_enabled == eLazyBoolYes;
+}
 #endif
 
 void Module::ReportErrorIfModifyDetected(const char *format, ...) {

lldb/source/Plugins/Language/Swift/SwiftLanguage.cpp

@@ -1090,7 +1090,7 @@ SwiftLanguage::GetHardcodedSynthetics() {
 
       Log *log(GetLog(LLDBLog::DataFormatters));
 
-      if (!valobj.GetTargetSP()->GetSwiftEnableCxxInterop())
+      if (!valobj.GetTargetSP()->IsSwiftCxxInteropEnabled())
         return nullptr;
 
       CompilerType type(valobj.GetCompilerType());

lldb/source/Plugins/TypeSystem/Swift/SwiftASTContext.cpp

@@ -1564,7 +1564,8 @@ SwiftASTContext::CreateInstance(lldb::LanguageType language, Module &module,
   swift_ast_sp->m_module = &module;
   swift_ast_sp->GetLanguageOptions().EnableAccessControl = false;
   swift_ast_sp->GetLanguageOptions().EnableCXXInterop =
-      Target::GetGlobalProperties().GetSwiftEnableCxxInterop();
+      module.IsSwiftCxxInteropEnabled();
+
   bool found_swift_modules = false;
   SymbolFile *sym_file = module.GetSymbolFile();
 
@@ -1950,7 +1951,7 @@ lldb::TypeSystemSP SwiftASTContext::CreateInstance(
   swift_ast_sp->m_is_scratch_context = true;
 
   swift_ast_sp->GetLanguageOptions().EnableCXXInterop =
-      target.GetSwiftEnableCxxInterop();
+      target.IsSwiftCxxInteropEnabled();
   bool handled_sdk_path = false;
   const size_t num_images = target.GetImages().GetSize();
 
@@ -4825,6 +4826,8 @@ void SwiftASTContext::LogConfiguration() {
   for (std::string &extra_arg : clang_importer_options.ExtraArgs) {
     HEALTH_LOG_PRINTF("    %s", extra_arg.c_str());
   }
+  HEALTH_LOG_PRINTF("  Swift/C++ interop mode: %s",
+                    m_ast_context_ap->LangOpts.EnableCXXInterop ? "on" : "off");
 }
 
 bool SwiftASTContext::HasTarget() {

lldb/source/Target/Target.cpp

@@ -2860,6 +2860,37 @@ bool Target::IsSwiftREPL() {
          GetProcessLaunchInfo().GetArg0().endswith("repl_swift");
 }
 
+bool Target::IsSwiftCxxInteropEnabled() {
+  switch (m_is_swift_cxx_interop_enabled) {
+  case eLazyBoolYes:
+    return true;
+  case eLazyBoolNo:
+    return false;
+  case eLazyBoolCalculate:
+    break;
+  }
+
+  EnableSwiftCxxInterop interop_enabled = GetEnableSwiftCxxInterop();
+  switch (interop_enabled) {
+  case eEnableSwiftCxxInterop:
+    m_is_swift_cxx_interop_enabled = eLazyBoolYes;
+    break;
+  case eDisableSwiftCxxInterop:
+    m_is_swift_cxx_interop_enabled = eLazyBoolNo;
+    break;
+  case eAutoDetectSwiftCxxInterop: {
+    if (GetImages().IsEmpty())
+      m_is_swift_cxx_interop_enabled = eLazyBoolNo;
+    else
+      m_is_swift_cxx_interop_enabled =
+          GetImages().GetModuleAtIndex(0)->IsSwiftCxxInteropEnabled()
+              ? eLazyBoolYes
+              : eLazyBoolNo;
+  }
+  }
+  return m_is_swift_cxx_interop_enabled == eLazyBoolYes;
+}
+
 #endif // LLDB_ENABLE_SWIFT
 
 void Target::SettingsInitialize() { Process::SettingsInitialize(); }
@@ -4385,6 +4416,13 @@ static constexpr OptionEnumValueElement g_memory_module_load_level_values[] = {
     },
 };
 
+static constexpr OptionEnumValueElement g_enable_swift_cxx_interop_values[] = {
+    {eAutoDetectSwiftCxxInterop, "auto",
+     "Automatically detect if C++ interop mode should be enabled."},
+    {eEnableSwiftCxxInterop, "true", "Enable C++ interop."},
+    {eDisableSwiftCxxInterop, "false", "Disable C++ interop."},
+};
+
 #define LLDB_PROPERTIES_target
 #include "TargetProperties.inc"
 
@@ -4605,16 +4643,14 @@ bool TargetProperties::GetSwiftEnableBareSlashRegex() const {
   return true;
 }
 
-bool TargetProperties::GetSwiftEnableCxxInterop() const {
-  const Property *exp_property = m_collection_sp->GetPropertyAtIndex(
-      nullptr, false, ePropertyExperimental);
-  OptionValueProperties *exp_values =
-      exp_property->GetValue()->GetAsProperties();
-  if (exp_values)
-    return exp_values->GetPropertyAtIndexAsBoolean(
-        nullptr, ePropertySwiftEnableCxxInterop, false);
+EnableSwiftCxxInterop TargetProperties::GetEnableSwiftCxxInterop() const {
+  const uint32_t idx = ePropertySwiftEnableCxxInterop;
 
-  return false;
+  EnableSwiftCxxInterop enable_interop =
+      (EnableSwiftCxxInterop)m_experimental_properties_up->GetValueProperties()
+          ->GetPropertyAtIndexAsEnumeration(
+              nullptr, idx, g_target_properties[idx].default_uint_value);
+  return enable_interop;
 }
 
 bool TargetProperties::GetSwiftAutoImportFrameworks() const {

lldb/source/Target/TargetProperties.td

@@ -19,8 +19,9 @@ let Definition = "target_experimental" in {
   def SwiftEnableBareSlashRegex: Property<"swift-enable-bare-slash-regex", "Boolean">,
     DefaultFalse,
     Desc<"Passes the -enable-bare-slash-regex compiler flag to the swift compiler.">;
-  def SwiftEnableCxxInterop: Property<"swift-enable-cxx-interop", "Boolean">,
-    DefaultFalse,
+  def SwiftEnableCxxInterop: Property<"swift-enable-cxx-interop", "Enum">,
+    DefaultEnumValue<"eAutoDetectSwiftCxxInterop">,
+    EnumValues<"OptionEnumValues(g_enable_swift_cxx_interop_values)">,
     Desc<"Passes the -enable-cxx-interop flag to the swift compiler.">;
 }
 

lldb/test/API/lang/swift/cxx_interop/backward/format-actors/TestSwiftBackwardInteropFormatActors.py

@@ -11,7 +11,7 @@ class TestSwiftBackwardInteropFormatActors(TestBase):
     @swiftTest
     def test_class(self):
         self.build()
-        self.runCmd('setting set target.experimental.swift-enable-cxx-interop true')
+        
         _, _, _, _= lldbutil.run_to_source_breakpoint(
             self, 'Set breakpoint here', lldb.SBFileSpec('main.cpp'))
 

lldb/test/API/lang/swift/cxx_interop/backward/format-swift-stdlib-types/TestSwiftBackwardInteropFormatSwiftStdlibTypes.py

@@ -9,7 +9,7 @@
 class TestSwiftBackwardInteropFormatSwiftStdlibTypes(TestBase):
     def setup(self, bkpt_str): 
         self.build()
-        self.runCmd('setting set target.experimental.swift-enable-cxx-interop true')
+        
         _, _, _, _= lldbutil.run_to_source_breakpoint(
             self, bkpt_str, lldb.SBFileSpec('main.cpp'))