[tsan] Fix a race during processUnitsAndWait() #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After we added processUnitsAndWait() as a separte entry point that ultimately called the onFilesChange() method, it created a race on the DoneInitState, which was accessed directly in the unit event callback before jumping to the unit processing queue. Simplify that logic and fix the race by using processUnitsAndWait() during initialization if we desire waiting, and get rid of DoneInitState. The previous approach was more flexible about allowing you to wait at an arbitrary point after creating the IndexDatastore, but in practice we were not using that ability, and it made it harder to understand the synchronization required.
Contributor
Author
|
@swift-ci please test |
akyrtzi
approved these changes
May 11, 2020
Contributor
Author
|
@swift-ci please test Linux |
Contributor
Author
|
swiftlang/swift-corelibs-foundation#2793 |
Contributor
Author
|
swiftlang/swift#31733 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we added processUnitsAndWait() as a separte entry point that
ultimately called the onFilesChange() method, it created a race on the
DoneInitState, which was accessed directly in the unit event callback
before jumping to the unit processing queue. Simplify that logic and fix
the race by using processUnitsAndWait() during initialization if we
desire waiting, and get rid of DoneInitState.
The previous approach was more flexible about allowing you to wait at an
arbitrary point after creating the IndexDatastore, but in practice we
were not using that ability, and it made it harder to understand the
synchronization required.