Separate build and e2e test, since the tests can only run on push and not on PR (#138)

* Separate build and e2e test, since the tests can only run on push and not on PR

* .

---------

Co-authored-by: Yair Morgenstern <[email protected]>

Author: yairm210

.github/workflows/build.yml

@@ -0,0 +1,15 @@
+name: "Build"
+on: [pull_request, push, workflow_dispatch]
+
+jobs:
+  build: # make sure build/ci work properly
+    name: Build on ${{ matrix.os }}
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest, windows-latest, macos-latest]
+    steps:
+    - uses: actions/checkout@v4
+    - run: |
+        npm install
+        npm run all

.github/workflows/ci.yml renamed to .github/workflows/e2e_test.yml

@@ -1,19 +1,11 @@
-name: "CI"
-on: [pull_request, push, workflow_dispatch]
+name: "E2E test"
+on: [push, workflow_dispatch]
 
-jobs:
-  build: # make sure build/ci work properly
-    name: CI on ${{ matrix.os }}
-    runs-on: ${{ matrix.os }}
-    strategy:
-      matrix:
-        os: [ubuntu-latest, windows-latest, macos-latest]
-    steps:
-    - uses: actions/checkout@v4
-    - run: |
-        npm install
-        npm run all
+# End to end tests require content permissions to create releases
+# This essentially gives permissions to make ANY change in the repository, so we should not grant this to PRs
+# This is an open issue for Github, see https://github.com/orgs/community/discussions/68252
 
+jobs:
   test: # make sure the action works on a clean machine without building
     name: E2E test
     runs-on: ${{ matrix.os }}