From c8ba7eebc51566c604c002b8d2c10aec8edff7a0 Mon Sep 17 00:00:00 2001 From: Nayan Gautam Date: Sun, 12 Nov 2023 10:06:31 +0545 Subject: [PATCH 1/4] enable dev mode for preview repl --- sites/svelte-5-preview/src/lib/workers/bundler/index.js | 7 ++++--- sites/svelte-5-preview/src/lib/workers/jsconfig.json | 9 +++++++++ 2 files changed, 13 insertions(+), 3 deletions(-) create mode 100644 sites/svelte-5-preview/src/lib/workers/jsconfig.json diff --git a/sites/svelte-5-preview/src/lib/workers/bundler/index.js b/sites/svelte-5-preview/src/lib/workers/bundler/index.js index 1e5c6cc02c88..80ad7354de4c 100644 --- a/sites/svelte-5-preview/src/lib/workers/bundler/index.js +++ b/sites/svelte-5-preview/src/lib/workers/bundler/index.js @@ -387,7 +387,8 @@ async function get_bundle(uid, mode, cache, local_files_lookup) { } else if (id.endsWith('.svelte')) { result = svelte.compile(code, { filename: name + '.svelte', - generate: 'client' + generate: 'client', + dev: true }); if (result.css) { @@ -400,7 +401,7 @@ async function get_bundle(uid, mode, cache, local_files_lookup) { `.replace(/\t/g, ''); } } else if (id.endsWith('.svelte.js')) { - result = svelte.compileModule(code, { filename: name + '.js', generate: 'client' }); + result = svelte.compileModule(code, { filename: name + '.js', generate: 'client', dev: true }); if (!result) { return null; } @@ -420,7 +421,7 @@ async function get_bundle(uid, mode, cache, local_files_lookup) { warnings.push(warning); }); - /** @type {import('rollup').TransformResult} */ + /** @type {import('@rollup/browser').TransformResult} */ const transform_result = { code: result.js.code, map: result.js.map diff --git a/sites/svelte-5-preview/src/lib/workers/jsconfig.json b/sites/svelte-5-preview/src/lib/workers/jsconfig.json new file mode 100644 index 000000000000..120f5730cb75 --- /dev/null +++ b/sites/svelte-5-preview/src/lib/workers/jsconfig.json @@ -0,0 +1,9 @@ +{ + "include": ["./**/*"], + "compilerOptions": { + "paths": { + "svelte": ["../../../static/svelte/main"], + "svelte/*": ["../../../static/svelte/*"] + } + } +} \ No newline at end of file From 70828f95652d394941e6184ec38312163e60e7f2 Mon Sep 17 00:00:00 2001 From: Nayan Gautam Date: Sun, 12 Nov 2023 10:22:34 +0545 Subject: [PATCH 2/4] format --- .../src/lib/workers/bundler/index.js | 6 +++++- .../src/lib/workers/jsconfig.json | 16 ++++++++-------- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/sites/svelte-5-preview/src/lib/workers/bundler/index.js b/sites/svelte-5-preview/src/lib/workers/bundler/index.js index 80ad7354de4c..15c43529cfc6 100644 --- a/sites/svelte-5-preview/src/lib/workers/bundler/index.js +++ b/sites/svelte-5-preview/src/lib/workers/bundler/index.js @@ -401,7 +401,11 @@ async function get_bundle(uid, mode, cache, local_files_lookup) { `.replace(/\t/g, ''); } } else if (id.endsWith('.svelte.js')) { - result = svelte.compileModule(code, { filename: name + '.js', generate: 'client', dev: true }); + result = svelte.compileModule(code, { + filename: name + '.js', + generate: 'client', + dev: true + }); if (!result) { return null; } diff --git a/sites/svelte-5-preview/src/lib/workers/jsconfig.json b/sites/svelte-5-preview/src/lib/workers/jsconfig.json index 120f5730cb75..60351b754815 100644 --- a/sites/svelte-5-preview/src/lib/workers/jsconfig.json +++ b/sites/svelte-5-preview/src/lib/workers/jsconfig.json @@ -1,9 +1,9 @@ { - "include": ["./**/*"], - "compilerOptions": { - "paths": { - "svelte": ["../../../static/svelte/main"], - "svelte/*": ["../../../static/svelte/*"] - } - } -} \ No newline at end of file + "include": ["./**/*"], + "compilerOptions": { + "paths": { + "svelte": ["../../../static/svelte/main"], + "svelte/*": ["../../../static/svelte/*"] + } + } +} From d71452ed36c23980ba9fd6f5efa4e3e62d876fc5 Mon Sep 17 00:00:00 2001 From: Nayan Gautam Date: Sun, 12 Nov 2023 12:47:05 +0545 Subject: [PATCH 3/4] also add dev mode toggle for compiler options --- .../svelte-5-preview/src/lib/Output/CompilerOptions.svelte | 7 +++++++ sites/svelte-5-preview/src/lib/Repl.svelte | 3 ++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/sites/svelte-5-preview/src/lib/Output/CompilerOptions.svelte b/sites/svelte-5-preview/src/lib/Output/CompilerOptions.svelte index 5f244a07fccf..60504c505272 100644 --- a/sites/svelte-5-preview/src/lib/Output/CompilerOptions.svelte +++ b/sites/svelte-5-preview/src/lib/Output/CompilerOptions.svelte @@ -1,6 +1,7 @@ @@ -16,6 +17,12 @@ + + }); diff --git a/sites/svelte-5-preview/src/lib/Repl.svelte b/sites/svelte-5-preview/src/lib/Repl.svelte index 5922a63ea85d..ff144d5d3285 100644 --- a/sites/svelte-5-preview/src/lib/Repl.svelte +++ b/sites/svelte-5-preview/src/lib/Repl.svelte @@ -76,7 +76,8 @@ /** @type {import('svelte/compiler').CompileOptions} */ const DEFAULT_COMPILE_OPTIONS = { - generate: 'client' + generate: 'client', + dev: false }; /** @type {Map} */ From 1798f5653421fca6f0f18f60b12ec57f53612233 Mon Sep 17 00:00:00 2001 From: Nayan Gautam Date: Sun, 12 Nov 2023 13:13:57 +0545 Subject: [PATCH 4/4] whoops --- sites/svelte-5-preview/src/lib/workers/compiler/index.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sites/svelte-5-preview/src/lib/workers/compiler/index.js b/sites/svelte-5-preview/src/lib/workers/compiler/index.js index 0563cdaffdc6..56ff24716138 100644 --- a/sites/svelte-5-preview/src/lib/workers/compiler/index.js +++ b/sites/svelte-5-preview/src/lib/workers/compiler/index.js @@ -59,7 +59,8 @@ function compile({ id, source, options, return_ast }) { if (options.filename.endsWith('.svelte')) { const compiled = svelte.compile(source, { filename: options.filename, - generate: options.generate + generate: options.generate, + dev: options.dev }); const { js, css, warnings, metadata } = compiled; @@ -77,7 +78,8 @@ function compile({ id, source, options, return_ast }) { } else if (options.filename.endsWith('.svelte.js')) { const compiled = svelte.compileModule(source, { filename: options.filename, - generate: options.generate + generate: options.generate, + dev: options.dev }); if (compiled) {