From 480d75ac0b936cb1b3a98a408b9858be18fab73d Mon Sep 17 00:00:00 2001 From: Nguyen Tran Date: Tue, 30 May 2023 13:25:49 -0400 Subject: [PATCH 1/4] Update PR checklist to reflect pnpm and new command checks --- .github/PULL_REQUEST_TEMPLATE.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 28234b69df87..0cebca10988b 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,6 +1,6 @@ # HEADS UP: BIG RESTRUCTURING UNDERWAY -The Svelte repo is currently in the process of heavy restructuring for Svelte 4. After that, work on Svelte 5 will likely change a lot on the compiler aswell. For that reason, please don't open PRs that are large in scope, touch more than a couple of files etc. In other words, bug fixes are fine, but feature PRs will likely not be merged. +The Svelte repo is currently in the process of heavy restructuring for Svelte 4. After that, work on Svelte 5 will likely change a lot on the compiler as well. For that reason, please don't open PRs that are large in scope, touch more than a couple of files, etc. In other words, bug fixes are fine, but feature PRs will likely not be merged. ### Before submitting the PR, please make sure you do the following - [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs @@ -8,5 +8,7 @@ The Svelte repo is currently in the process of heavy restructuring for Svelte 4. - [ ] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. -### Tests -- [ ] Run the tests with `npm test` and lint the project with `npm run lint` +### Tests, lints, formatting +- [ ] Run the tests with `pnpm test` +- [ ] Lint the project with `pnpm lint` +- [ ] Format the project with either your Prettier plugin or `pnpm format` From 3f3cfce80657c564c1f9e90713f0294d83cccfbd Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Tue, 30 May 2023 12:18:01 -0700 Subject: [PATCH 2/4] Update .github/PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 0cebca10988b..d9a11b30ebbf 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -11,4 +11,3 @@ The Svelte repo is currently in the process of heavy restructuring for Svelte 4. ### Tests, lints, formatting - [ ] Run the tests with `pnpm test` - [ ] Lint the project with `pnpm lint` -- [ ] Format the project with either your Prettier plugin or `pnpm format` From cba84e4d7c6705d089a20e57565cb4a0b4b8052d Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Tue, 30 May 2023 12:18:06 -0700 Subject: [PATCH 3/4] Update .github/PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index d9a11b30ebbf..299af85b59d0 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,6 +1,6 @@ # HEADS UP: BIG RESTRUCTURING UNDERWAY -The Svelte repo is currently in the process of heavy restructuring for Svelte 4. After that, work on Svelte 5 will likely change a lot on the compiler as well. For that reason, please don't open PRs that are large in scope, touch more than a couple of files, etc. In other words, bug fixes are fine, but feature PRs will likely not be merged. +The Svelte repo is currently in the process of heavy restructuring for Svelte 4. After that, work on Svelte 5 will likely change a lot in the compiler as well. For that reason, please don't open PRs that are large in scope, touch more than a couple of files, etc. In other words, bug fixes are fine, but feature PRs will likely not be merged. ### Before submitting the PR, please make sure you do the following - [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs From b5ef13723631b24cfb4ede65b64ef5db59781c77 Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Tue, 30 May 2023 12:19:16 -0700 Subject: [PATCH 4/4] Update .github/PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 299af85b59d0..34f35c5a70c4 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -8,6 +8,5 @@ The Svelte repo is currently in the process of heavy restructuring for Svelte 4. - [ ] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. -### Tests, lints, formatting -- [ ] Run the tests with `pnpm test` -- [ ] Lint the project with `pnpm lint` +### Tests and linting +- [ ] Run the tests with `pnpm test` and lint the project with `pnpm lint`