Skip to content

Conversation

@mkhan45
Copy link
Contributor

@mkhan45 mkhan45 commented Nov 5, 2020

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

This error message has a typo:
An element that use the animate directive must be the immediate child of a keyed each block

It should instead be
An element that uses the animate directive must be the immediate child of a keyed each block

or maybe
Elements that use the animate directive must be the immediate child of a keyed each block.

I decided on the former.

I'm not sure if this is worth the PR but it was bugging me

@benmccann benmccann merged commit 9745b61 into sveltejs:master Nov 6, 2020
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants