From e648e423d4929426c71bdcd676131875b2d2fa1d Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Fri, 15 Aug 2025 10:18:41 -0400 Subject: [PATCH 1/3] update/simplify test --- .../samples/effect-order-6/A.svelte | 7 ++++--- .../samples/effect-order-6/B.svelte | 4 +--- .../samples/effect-order-6/Child.svelte | 20 ------------------- .../samples/effect-order-6/main.svelte | 20 ++++++++++++------- 4 files changed, 18 insertions(+), 33 deletions(-) delete mode 100644 packages/svelte/tests/runtime-runes/samples/effect-order-6/Child.svelte diff --git a/packages/svelte/tests/runtime-runes/samples/effect-order-6/A.svelte b/packages/svelte/tests/runtime-runes/samples/effect-order-6/A.svelte index 2e789a046007..efc6d58b306f 100644 --- a/packages/svelte/tests/runtime-runes/samples/effect-order-6/A.svelte +++ b/packages/svelte/tests/runtime-runes/samples/effect-order-6/A.svelte @@ -1,11 +1,12 @@ - + diff --git a/packages/svelte/tests/runtime-runes/samples/effect-order-6/B.svelte b/packages/svelte/tests/runtime-runes/samples/effect-order-6/B.svelte index 1fad19bc1568..22339611773a 100644 --- a/packages/svelte/tests/runtime-runes/samples/effect-order-6/B.svelte +++ b/packages/svelte/tests/runtime-runes/samples/effect-order-6/B.svelte @@ -1,7 +1,5 @@ - - - -{#if object?.boolean} - - {@render children(object.boolean)} -{/if} diff --git a/packages/svelte/tests/runtime-runes/samples/effect-order-6/main.svelte b/packages/svelte/tests/runtime-runes/samples/effect-order-6/main.svelte index eee487fa132f..08f6fc48da0d 100644 --- a/packages/svelte/tests/runtime-runes/samples/effect-order-6/main.svelte +++ b/packages/svelte/tests/runtime-runes/samples/effect-order-6/main.svelte @@ -1,6 +1,15 @@ @@ -15,9 +24,6 @@
- - {#snippet children(boolean)} - - {/snippet} - - +{#if object} + +{/if} From d61b3e8772f73c65e6339337d568f68acf6e9c67 Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Fri, 15 Aug 2025 11:10:00 -0400 Subject: [PATCH 2/3] oops --- .../svelte/tests/runtime-runes/samples/effect-order-6/A.svelte | 2 +- .../tests/runtime-runes/samples/effect-order-6/_config.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/svelte/tests/runtime-runes/samples/effect-order-6/A.svelte b/packages/svelte/tests/runtime-runes/samples/effect-order-6/A.svelte index efc6d58b306f..22b8ed0f20fb 100644 --- a/packages/svelte/tests/runtime-runes/samples/effect-order-6/A.svelte +++ b/packages/svelte/tests/runtime-runes/samples/effect-order-6/A.svelte @@ -5,7 +5,7 @@ // this runs after the effect in B, because child effects run first $effect(() => { - console.log(boolean, closed); + console.log({ boolean, closed }); }); diff --git a/packages/svelte/tests/runtime-runes/samples/effect-order-6/_config.js b/packages/svelte/tests/runtime-runes/samples/effect-order-6/_config.js index 8f9077e9544b..91e1569e46aa 100644 --- a/packages/svelte/tests/runtime-runes/samples/effect-order-6/_config.js +++ b/packages/svelte/tests/runtime-runes/samples/effect-order-6/_config.js @@ -8,6 +8,6 @@ export default test({ flushSync(() => open.click()); flushSync(() => close.click()); - assert.deepEqual(logs, [true]); + assert.deepEqual(logs, [{ boolean: true, closed: false }]); } }); From 0ea096e763ac6a9cd5fe62d7b5acf3a68a0a5b04 Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Fri, 15 Aug 2025 11:53:45 -0400 Subject: [PATCH 3/3] simplify effect-order-7 --- .../samples/effect-order-7/A.svelte | 6 +++--- .../samples/effect-order-7/B.svelte | 4 +--- .../samples/effect-order-7/Child.svelte | 20 ------------------- .../samples/effect-order-7/main.svelte | 19 ++++++++++++------ 4 files changed, 17 insertions(+), 32 deletions(-) delete mode 100644 packages/svelte/tests/runtime-runes/samples/effect-order-7/Child.svelte diff --git a/packages/svelte/tests/runtime-runes/samples/effect-order-7/A.svelte b/packages/svelte/tests/runtime-runes/samples/effect-order-7/A.svelte index 54f4869d6252..b55c8f4115a3 100644 --- a/packages/svelte/tests/runtime-runes/samples/effect-order-7/A.svelte +++ b/packages/svelte/tests/runtime-runes/samples/effect-order-7/A.svelte @@ -1,9 +1,9 @@ -{boolean} +{boolean} {closed} - + diff --git a/packages/svelte/tests/runtime-runes/samples/effect-order-7/B.svelte b/packages/svelte/tests/runtime-runes/samples/effect-order-7/B.svelte index 2a2e634db156..7b33c342f526 100644 --- a/packages/svelte/tests/runtime-runes/samples/effect-order-7/B.svelte +++ b/packages/svelte/tests/runtime-runes/samples/effect-order-7/B.svelte @@ -1,7 +1,5 @@ - - - -{#if object?.nested} - - {@render children(object.nested)} -{/if} diff --git a/packages/svelte/tests/runtime-runes/samples/effect-order-7/main.svelte b/packages/svelte/tests/runtime-runes/samples/effect-order-7/main.svelte index c9c45c50cf4d..d9e9eb17ada2 100644 --- a/packages/svelte/tests/runtime-runes/samples/effect-order-7/main.svelte +++ b/packages/svelte/tests/runtime-runes/samples/effect-order-7/main.svelte @@ -1,6 +1,15 @@ @@ -15,8 +24,6 @@
- - {#snippet children(nested)} -
- {/snippet} - +{#if object} + +{/if}