Skip to content

Conversation

@adiguba
Copy link
Contributor

@adiguba adiguba commented Feb 15, 2025

When I write #15185 I have added an options on the render() function, allowing to pass a custom uid-generator.

I totally forgot to mention it on the PR, and now I think that it is useless and should not be there.

This option is not documented and not declared in typescript definition of render().
So I think it's better to remove it.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@github-actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15302

@paoloricciuti
Copy link
Member

Despite it not being public API I think we still need a change set for this then we are good to go

@changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2025

🦋 Changeset detected

Latest commit: 3b344a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@adiguba
Copy link
Contributor Author

adiguba commented Feb 15, 2025

Done ;)

@paoloricciuti paoloricciuti merged commit c40392c into sveltejs:main Feb 15, 2025
9 checks passed
@github-actions github-actions bot mentioned this pull request Feb 15, 2025
@Hugos68
Copy link
Contributor

Hugos68 commented Feb 27, 2025

To solve a bug in Astro: withastro/astro#13327 we need access to this API, can we add it back? I wouldn't mind sending PR.

@adiguba
Copy link
Contributor Author

adiguba commented Feb 27, 2025

Yes it seems that it is required for your case.

Note that I'm not sure if this API worked.
I considered it but never tested it...

But since this would become a public API, the maintainers' opinion is required...

@Hugos68
Copy link
Contributor

Hugos68 commented Feb 27, 2025

@adiguba I've asked in the discord and @dummdidumm gave me the go ahead, I'll link this issue when I have something working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants