From 542cda3f6853838ea18cf8465a4d14c809829915 Mon Sep 17 00:00:00 2001 From: tomoam <29677552+tomoam@users.noreply.github.com> Date: Thu, 13 Feb 2025 18:54:23 +0900 Subject: [PATCH 1/3] fix: prevent writable store value from becoming a proxy when reassigning using $ prefix --- .../client/visitors/AssignmentExpression.js | 1 + .../samples/store-reassign-object/_config.js | 10 ++++++++++ .../samples/store-reassign-object/main.svelte | 11 +++++++++++ 3 files changed, 22 insertions(+) create mode 100644 packages/svelte/tests/runtime-runes/samples/store-reassign-object/_config.js create mode 100644 packages/svelte/tests/runtime-runes/samples/store-reassign-object/main.svelte diff --git a/packages/svelte/src/compiler/phases/3-transform/client/visitors/AssignmentExpression.js b/packages/svelte/src/compiler/phases/3-transform/client/visitors/AssignmentExpression.js index 0c70f7e00cda..a8c615af936f 100644 --- a/packages/svelte/src/compiler/phases/3-transform/client/visitors/AssignmentExpression.js +++ b/packages/svelte/src/compiler/phases/3-transform/client/visitors/AssignmentExpression.js @@ -118,6 +118,7 @@ function build_assignment(operator, left, right, context) { binding.kind !== 'prop' && binding.kind !== 'bindable_prop' && binding.kind !== 'raw_state' && + binding.kind !== 'store_sub' && context.state.analysis.runes && should_proxy(right, context.state.scope) && is_non_coercive_operator(operator) diff --git a/packages/svelte/tests/runtime-runes/samples/store-reassign-object/_config.js b/packages/svelte/tests/runtime-runes/samples/store-reassign-object/_config.js new file mode 100644 index 000000000000..3cded0a7e0a4 --- /dev/null +++ b/packages/svelte/tests/runtime-runes/samples/store-reassign-object/_config.js @@ -0,0 +1,10 @@ +import { test } from '../../test'; + +export default test({ + async test({ target, assert }) { + assert.htmlEqual( + target.innerHTML, + `
bar
` + ); + } +}); diff --git a/packages/svelte/tests/runtime-runes/samples/store-reassign-object/main.svelte b/packages/svelte/tests/runtime-runes/samples/store-reassign-object/main.svelte new file mode 100644 index 000000000000..ecffbb2d837c --- /dev/null +++ b/packages/svelte/tests/runtime-runes/samples/store-reassign-object/main.svelte @@ -0,0 +1,11 @@ + + +{clone.name}
From 8b326b0ea77a2614869212c05e2832d531025010 Mon Sep 17 00:00:00 2001 From: tomoam <29677552+tomoam@users.noreply.github.com> Date: Thu, 13 Feb 2025 19:09:59 +0900 Subject: [PATCH 2/3] format --- .../runtime-runes/samples/store-reassign-object/_config.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/svelte/tests/runtime-runes/samples/store-reassign-object/_config.js b/packages/svelte/tests/runtime-runes/samples/store-reassign-object/_config.js index 3cded0a7e0a4..f9a329889d21 100644 --- a/packages/svelte/tests/runtime-runes/samples/store-reassign-object/_config.js +++ b/packages/svelte/tests/runtime-runes/samples/store-reassign-object/_config.js @@ -2,9 +2,6 @@ import { test } from '../../test'; export default test({ async test({ target, assert }) { - assert.htmlEqual( - target.innerHTML, - `bar
` - ); + assert.htmlEqual(target.innerHTML, `bar
`); } }); From 5aa2b7c8b5105940bfbaaf7d755ac0cf8cf8e90c Mon Sep 17 00:00:00 2001 From: tomoam <29677552+tomoam@users.noreply.github.com> Date: Thu, 13 Feb 2025 19:16:05 +0900 Subject: [PATCH 3/3] add changeset --- .changeset/lovely-chairs-compete.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/lovely-chairs-compete.md diff --git a/.changeset/lovely-chairs-compete.md b/.changeset/lovely-chairs-compete.md new file mode 100644 index 000000000000..d311a3dde6f0 --- /dev/null +++ b/.changeset/lovely-chairs-compete.md @@ -0,0 +1,5 @@ +--- +'svelte': patch +--- + +fix: prevent writable store value from becoming a proxy when reassigning using $-prefix