-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix: add check for is attribute #15086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
72963d4
fix: add check for is attribute
edoardocavazza 37e8694
chore: add tests for custom elements properties
edoardocavazza dc727e5
Create two-doors-exercise.md
edoardocavazza ba37bbc
chore: fix lint
paoloricciuti 72fab2b
fix: improve custom element checks in html validation
edoardocavazza 57137e6
Revert "fix: improve custom element checks in html validation"
edoardocavazza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "svelte": patch | ||
| --- | ||
|
|
||
| fix: add check for `is` attribute to correctly detect custom elements |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
packages/svelte/tests/runtime-runes/samples/custom-element-attributes/_config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import { test } from '../../test'; | ||
|
|
||
| export default test({ | ||
| mode: ['client', 'server'], | ||
| async test({ assert, target }) { | ||
| const my_element = /** @type HTMLElement & { object: { test: true }; } */ ( | ||
| target.querySelector('my-element') | ||
| ); | ||
| const my_link = /** @type HTMLAnchorElement & { object: { test: true }; } */ ( | ||
| target.querySelector('a') | ||
| ); | ||
| assert.equal(my_element.getAttribute('string'), 'test'); | ||
| assert.equal(my_element.hasAttribute('object'), false); | ||
| assert.deepEqual(my_element.object, { test: true }); | ||
| assert.equal(my_link.getAttribute('string'), 'test'); | ||
| assert.equal(my_link.hasAttribute('object'), false); | ||
| assert.deepEqual(my_link.object, { test: true }); | ||
| } | ||
| }); |
2 changes: 2 additions & 0 deletions
2
packages/svelte/tests/runtime-runes/samples/custom-element-attributes/main.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| <my-element string="test" object={{ test: true }}></my-element> | ||
| <a is="my-link" string="test" object={{ test: true }}></a> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.