diff --git a/.changeset/clean-bobcats-fail.md b/.changeset/clean-bobcats-fail.md new file mode 100644 index 000000000000..00d8286bcb28 --- /dev/null +++ b/.changeset/clean-bobcats-fail.md @@ -0,0 +1,5 @@ +--- +'svelte': patch +--- + +fix: ensure $state.snapshot clones holey arrays correctly diff --git a/packages/svelte/src/internal/shared/clone.js b/packages/svelte/src/internal/shared/clone.js index cef14bc14f9e..4632fc3d68ed 100644 --- a/packages/svelte/src/internal/shared/clone.js +++ b/packages/svelte/src/internal/shared/clone.js @@ -54,22 +54,25 @@ export function snapshot(value, skip_warning = false) { */ function clone(value, cloned, path, paths, original = null) { if (typeof value === 'object' && value !== null) { - const unwrapped = cloned.get(value); + var unwrapped = cloned.get(value); if (unwrapped !== undefined) return unwrapped; if (value instanceof Map) return /** @type {Snapshot} */ (new Map(value)); if (value instanceof Set) return /** @type {Snapshot} */ (new Set(value)); if (is_array(value)) { - const copy = /** @type {Snapshot} */ ([]); + var copy = /** @type {Snapshot} */ (Array(value.length)); cloned.set(value, copy); if (original !== null) { cloned.set(original, copy); } - for (let i = 0; i < value.length; i += 1) { - copy.push(clone(value[i], cloned, DEV ? `${path}[${i}]` : path, paths)); + for (var i = 0; i < value.length; i += 1) { + var element = value[i]; + if (i in value) { + copy[i] = clone(element, cloned, DEV ? `${path}[${i}]` : path, paths); + } } return copy; @@ -77,7 +80,7 @@ function clone(value, cloned, path, paths, original = null) { if (get_prototype_of(value) === object_prototype) { /** @type {Snapshot} */ - const copy = {}; + copy = {}; cloned.set(value, copy); if (original !== null) { diff --git a/packages/svelte/tests/runtime-runes/samples/state-snapshot-array-holes/_config.js b/packages/svelte/tests/runtime-runes/samples/state-snapshot-array-holes/_config.js new file mode 100644 index 000000000000..707c92118bf3 --- /dev/null +++ b/packages/svelte/tests/runtime-runes/samples/state-snapshot-array-holes/_config.js @@ -0,0 +1,5 @@ +import { test } from '../../test'; + +export default test({ + html: `
false
true
` +}); diff --git a/packages/svelte/tests/runtime-runes/samples/state-snapshot-array-holes/main.svelte b/packages/svelte/tests/runtime-runes/samples/state-snapshot-array-holes/main.svelte new file mode 100644 index 000000000000..cb5c116f37f1 --- /dev/null +++ b/packages/svelte/tests/runtime-runes/samples/state-snapshot-array-holes/main.svelte @@ -0,0 +1,10 @@ + + +
{2 in $state.snapshot(state)}
+
{5 in $state.snapshot(state)}