From dae3d950de7eeb977e4bf8ee3a4cefdc586cf5f8 Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Mon, 29 Jan 2024 14:24:01 -0500 Subject: [PATCH 1/3] disallow TODO errors --- packages/svelte/src/compiler/errors.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/svelte/src/compiler/errors.js b/packages/svelte/src/compiler/errors.js index 910f5fd65103..3006dca54e68 100644 --- a/packages/svelte/src/compiler/errors.js +++ b/packages/svelte/src/compiler/errors.js @@ -508,7 +508,7 @@ export class CompileError extends Error { } /** - * @template {keyof typeof errors} T + * @template {Exclude} T * @param {NodeLike | number | null} node * @param {T} code * @param {Parameters} args From f2bf89967988cb2c59e7f7d16e84c523174a98f0 Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Mon, 29 Jan 2024 14:32:42 -0500 Subject: [PATCH 2/3] replace TODO errors --- packages/svelte/src/compiler/errors.js | 4 +++- packages/svelte/src/compiler/phases/1-parse/state/tag.js | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/svelte/src/compiler/errors.js b/packages/svelte/src/compiler/errors.js index 3006dca54e68..98741e29f40d 100644 --- a/packages/svelte/src/compiler/errors.js +++ b/packages/svelte/src/compiler/errors.js @@ -88,7 +88,9 @@ const parse = { 'illegal-subscription': () => `Cannot reference store value inside