Skip to content

Commit fe60894

Browse files
authored
fix(sites): fix REPL styles (#8770)
* Push * Push fixes * Delete vite.config.js.timestamp-1687278902174-a59162675b2f6.mjs * Remove log * bump site-ki
1 parent 3858321 commit fe60894

File tree

6 files changed

+17
-11
lines changed

6 files changed

+17
-11
lines changed

pnpm-lock.yaml

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sites/svelte.dev/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"@resvg/resvg-js": "^2.4.1",
3131
"@sveltejs/adapter-vercel": "^3.0.1",
3232
"@sveltejs/kit": "^1.20.4",
33-
"@sveltejs/site-kit": "6.0.0-next.6",
33+
"@sveltejs/site-kit": "6.0.0-next.8",
3434
"@sveltejs/vite-plugin-svelte": "^2.4.1",
3535
"@types/marked": "^5.0.0",
3636
"@types/node": "^20.3.1",

sites/svelte.dev/src/app.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,6 @@
3030
%sveltekit.head%
3131
</head>
3232
<body data-sveltekit-preload-code="hover">
33-
<div>%sveltekit.body%</div>
33+
<div style="height: 100%">%sveltekit.body%</div>
3434
</body>
3535
</html>

sites/svelte.dev/src/routes/(authed)/repl/[id]/+page.server.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,6 @@ export async function load({ fetch, params, url }) {
1111

1212
return {
1313
gist,
14-
version: url.searchParams.get('version') || '3'
14+
version: url.searchParams.get('version') || '4.0.0-next.2'
1515
};
1616
}

sites/svelte.dev/src/routes/(authed)/repl/[id]/+page.svelte

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
3333
onMount(() => {
3434
if (data.version !== 'local') {
35-
fetch(`https://unpkg.com/svelte@${data.version || '3'}/package.json`)
35+
fetch(`https://unpkg.com/svelte@${data.version || '4.0.0-next.2'}/package.json`)
3636
.then((r) => r.json())
3737
.then((pkg) => {
3838
version = pkg.version;
@@ -101,7 +101,8 @@
101101
<style>
102102
.repl-outer {
103103
position: relative;
104-
height: calc(100vh - var(--sk-nav-height));
104+
height: calc(100% - var(--sk-nav-height));
105+
height: calc(100dvh - var(--sk-nav-height));
105106
--app-controls-h: 5.6rem;
106107
--pane-controls-h: 4.2rem;
107108
overflow: hidden;

sites/svelte.dev/src/routes/tutorial/[slug]/+page.svelte

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,15 +67,20 @@
6767
$: mobile = width < 768;
6868
6969
function reset() {
70-
repl.update({
70+
repl.set({
7171
files: data.tutorial.initial.map(clone)
7272
});
73+
74+
//! BUG: Fix handleChange on REPL side, setting repl.set doesn't trigger it, and repl.update doesn't even work
75+
completed = false;
7376
}
7477
7578
function complete() {
76-
repl.update({
79+
repl.set({
7780
files: data.tutorial.complete.map(clone)
7881
});
82+
83+
completed = true;
7984
}
8085
8186
let completed = false;

0 commit comments

Comments
 (0)