fix: ensure effect cleanup functions are called with null this

Author: Rich-Harris

.changeset/fuzzy-donuts-provide.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: ensure effect cleanup functions are called with null `this`

packages/svelte/src/internal/client/reactivity/effects.js

@@ -245,7 +245,7 @@ export function destroy_effect(effect) {
 		}
 	}
 
-	effect.teardown?.();
+	effect.teardown?.call(null);
 
 	if (effect.dom !== null) {
 		remove(effect.dom);

packages/svelte/src/internal/client/runtime.js

@@ -390,7 +390,7 @@ export function execute_effect(effect) {
 			destroy_effect_children(effect);
 		}
 
-		effect.teardown?.();
+		effect.teardown?.call(null);
 		var teardown = execute_reaction_fn(effect);
 		effect.teardown = typeof teardown === 'function' ? teardown : null;
 	} finally {

packages/svelte/tests/runtime-runes/samples/effect-cleanup/_config.js

@@ -15,6 +15,6 @@ export default test({
 		flushSync(() => {
 			b1.click();
 		});
-		assert.deepEqual(log, ['init 0', 'cleanup 2', 'init 2', 'cleanup 4', 'init 4']);
+		assert.deepEqual(log, ['init 0', 'cleanup 2', null, 'init 2', 'cleanup 4', null, 'init 4']);
 	}
 });

packages/svelte/tests/runtime-runes/samples/effect-cleanup/main.svelte

@@ -8,8 +8,10 @@
 
 		log.push('init ' + double);
 
-		return () => {
+		return function() {
 			log.push('cleanup ' + double);
+			// @ts-expect-error
+			log.push(this);
 		};
 	})
 </script>