Skip to content

Commit de9efe2

Browse files
committed
fix: prevent svelte_component_invalid_this_value false positives
Also check for the function name: `$$component` is rare enough (if even allowed - it's not inside `.svelte(.js)` files) to remove most of not all false positives
1 parent af35fb7 commit de9efe2

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

.changeset/rotten-glasses-own.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'svelte': patch
3+
---
4+
5+
fix: prevent `svelte_component_invalid_this_value` false positives

packages/svelte/src/internal/client/validate.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export function validate_dynamic_component(component_fn) {
3131
} catch (err) {
3232
const { message } = /** @type {Error} */ (err);
3333

34-
if (typeof message === 'string' && message.indexOf('is not a function') !== -1) {
34+
if (typeof message === 'string' && message.indexOf('$$component is not a function') !== -1) {
3535
e.svelte_component_invalid_this_value();
3636
}
3737

0 commit comments

Comments
 (0)