Skip to content

Commit dd061f8

Browse files
committed
fix: fixed some broken tests related with the new way of dealing with old and new event-handling syntaxes
1 parent 8eab284 commit dd061f8

File tree

17 files changed

+118
-27
lines changed

17 files changed

+118
-27
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<script>
2+
const { children, ...props } = $props();
3+
</script>
4+
5+
<button {...props} on:click>
6+
{@render children()}
7+
</button>
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
import { test } from '../../test';
2+
3+
export default test({
4+
html: `<button>0</button><button>0</button>`,
5+
6+
async test({ assert, target }) {
7+
const [b1, b2] = target.querySelectorAll('button');
8+
9+
b1?.click();
10+
await Promise.resolve();
11+
assert.htmlEqual(target.innerHTML, '<button>1</button><button>1</button>');
12+
13+
b2?.click();
14+
await Promise.resolve();
15+
assert.htmlEqual(target.innerHTML, '<button>2</button><button>2</button>');
16+
}
17+
});
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<script>
2+
import Button from './Button.svelte';
3+
let count = $state(0);
4+
const onclick = () => count++;
5+
</script>
6+
7+
<Button on:click={onclick}>{count}</Button>
8+
<Button onclick={onclick}>{count}</Button>

packages/svelte/tests/runtime-runes/samples/event-attribute-delegation-2/main.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div on:click={(e) => { console.log('clicked div') }}>
1+
<div onclick={(e) => { console.log('clicked div') }}>
22
<button onclick={(e) => { console.log('clicked button'); e.stopPropagation() }}>
33
Button
44
</button>
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<script>
2+
const { children, ...props } = $props();
3+
</script>
4+
5+
<div {...props} on:click>
6+
{@render children()}
7+
</div>
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
<script>
2+
import Component from "./Component.svelte";
23
import Sub from "./sub.svelte";
34
</script>
45

56
<svelte:window onclick="{() => console.log('window main')}" />
67
<svelte:document onclick="{() => console.log('document main')}" />
78

8-
<div on:click={() => console.log('div main 1')} on:click={() => console.log('div main 2')}>
9+
<Component on:click={() => console.log('div main 1')} on:click={() => console.log('div main 2')}>
910
<button onclick={() => console.log('button main')}>main</button>
10-
</div>
11+
</Component>
1112

1213
<Sub />
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<script>
2+
const { children, ...props } = $props();
3+
</script>
4+
5+
<button {...props} on:click>
6+
{@render children()}
7+
</button>
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<script>
2+
const { children, ...props } = $props();
3+
</script>
4+
5+
<div {...props} on:click>
6+
{@render children()}
7+
</div>
Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
1-
<div onclick={() => console.log('outer div onclick')}>
2-
<div on:click={() => console.log('inner div on:click')}>
3-
<button onclick={() => console.log('button onclick')} on:click={() => console.log('button on:click')}>main</button>
4-
</div>
5-
</div>
1+
<script>
2+
import Component from "./Component.svelte";
3+
import Button from "./Button.svelte";
4+
</script>
5+
6+
<Component onclick={() => console.log('outer div onclick')}>
7+
<Component on:click={() => console.log('inner div on:click')}>
8+
<Button onclick={() => console.log('button onclick')} on:click={() => console.log('button on:click')}>main</Button>
9+
</Component>
10+
</Component>
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<script>
2+
const { children, ...props } = $props();
3+
</script>
4+
5+
<button {...props} on:click>
6+
{@render children()}
7+
</button>

0 commit comments

Comments
 (0)