breaking: rename svelte/reactivity helpers to include Svelte prefix (#12248)

* breaking: rename svelte/reactivity helpers to include Svelte prefix

* keep old exports

* add runtime errors

* add runtime errors

* feedback

* feedback

* feedback

* Update .changeset/nice-jobs-breathe.md

Co-authored-by: Conduitry <[email protected]>

---------

Co-authored-by: Conduitry <[email protected]>

Author: trueadm

.changeset/nice-jobs-breathe.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+breaking: rename `svelte/reactivity` helpers to include `Svelte` prefix

packages/svelte/src/reactivity/date.js

@@ -57,14 +57,14 @@ const write = [
 
 var inited = false;
 
-export class ReactiveDate extends Date {
+export class SvelteDate extends Date {
 	#raw_time = source(super.getTime());
 
 	// We init as part of the first instance so that we can treeshake this class
 	#init() {
 		if (!inited) {
 			inited = true;
-			const proto = ReactiveDate.prototype;
+			const proto = SvelteDate.prototype;
 			const date_proto = Date.prototype;
 
 			for (const method of read) {

packages/svelte/src/reactivity/index-client.js

@@ -1,4 +1,29 @@
-export { ReactiveDate as Date } from './date.js';
-export { ReactiveSet as Set } from './set.js';
-export { ReactiveMap as Map } from './map.js';
-export { ReactiveURL as URL, ReactiveURLSearchParams as URLSearchParams } from './url.js';
+export { SvelteDate } from './date.js';
+export { SvelteSet } from './set.js';
+export { SvelteMap } from './map.js';
+export { SvelteURL, SvelteURLSearchParams } from './url.js';
+
+/** @deprecated Use `SvelteDate` instead */
+export function Date() {
+	throw new Error('Date has been removed, use SvelteDate instead.');
+}
+
+/** @deprecated Use `SvelteSet` instead */
+export function Set() {
+	throw new Error('Set has been removed, use SvelteSet instead.');
+}
+
+/** @deprecated Use `SvelteMap` instead */
+export function Map() {
+	throw new Error('Map has been removed, use SvelteMap instead.');
+}
+
+/** @deprecated Use `SvelteURL` instead */
+export function URL() {
+	throw new Error('URL has been removed, use SvelteURL instead.');
+}
+
+/** @deprecated Use `SvelteURLSearchParams` instead */
+export function URLSearchParams() {
+	throw new Error('URLSearchParams has been removed, use SvelteURLSearchParams instead.');
+}

packages/svelte/src/reactivity/index-server.js

@@ -1,5 +1,30 @@
-export const Date = globalThis.Date;
-export const Set = globalThis.Set;
-export const Map = globalThis.Map;
-export const URL = globalThis.URL;
-export const URLSearchParams = globalThis.URLSearchParams;
+export const SvelteDate = globalThis.Date;
+export const SvelteSet = globalThis.Set;
+export const SvelteMap = globalThis.Map;
+export const SvelteURL = globalThis.URL;
+export const SvelteURLSearchParams = globalThis.URLSearchParams;
+
+/** @deprecated Use `SvelteDate` instead */
+export function Date() {
+	throw new Error('Date has been removed, use SvelteDate instead.');
+}
+
+/** @deprecated Use `SvelteSet` instead */
+export function Set() {
+	throw new Error('Set has been removed, use SvelteSet instead.');
+}
+
+/** @deprecated Use `SvelteMap` instead */
+export function Map() {
+	throw new Error('Map has been removed, use SvelteMap instead.');
+}
+
+/** @deprecated Use `SvelteURL` instead */
+export function URL() {
+	throw new Error('URL has been removed, use SvelteURL instead.');
+}
+
+/** @deprecated Use `SvelteURLSearchParams` instead */
+export function URLSearchParams() {
+	throw new Error('URLSearchParams has been removed, use SvelteURLSearchParams instead.');
+}

packages/svelte/src/reactivity/map.js

@@ -8,7 +8,7 @@ import { increment } from './utils.js';
  * @template V
  * @extends {Map<K, V>}
  */
-export class ReactiveMap extends Map {
+export class SvelteMap extends Map {
 	/** @type {Map<K, import('#client').Source<number>>} */
 	#sources = new Map();
 	#version = source(0);

packages/svelte/src/reactivity/map.test.ts

@@ -1,10 +1,10 @@
 import { render_effect, effect_root } from '../internal/client/reactivity/effects.js';
 import { flushSync } from '../index-client.js';
-import { ReactiveMap } from './map.js';
+import { SvelteMap } from './map.js';
 import { assert, test } from 'vitest';
 
 test('map.values()', () => {
-	const map = new ReactiveMap([
+	const map = new SvelteMap([
 		[1, 1],
 		[2, 2],
 		[3, 3],
@@ -65,7 +65,7 @@ test('map.values()', () => {
 });
 
 test('map.get(...)', () => {
-	const map = new ReactiveMap([
+	const map = new SvelteMap([
 		[1, 1],
 		[2, 2],
 		[3, 3]
@@ -101,7 +101,7 @@ test('map.get(...)', () => {
 });
 
 test('map.has(...)', () => {
-	const map = new ReactiveMap([
+	const map = new SvelteMap([
 		[1, 1],
 		[2, 2],
 		[3, 3]
@@ -148,7 +148,7 @@ test('map.has(...)', () => {
 });
 
 test('map.forEach(...)', () => {
-	const map = new ReactiveMap([
+	const map = new SvelteMap([
 		[1, 1],
 		[2, 2],
 		[3, 3]
@@ -169,7 +169,7 @@ test('map.forEach(...)', () => {
 });
 
 test('map.delete(...)', () => {
-	const map = new ReactiveMap([
+	const map = new SvelteMap([
 		[1, 1],
 		[2, 2],
 		[3, 3]
@@ -182,7 +182,7 @@ test('map.delete(...)', () => {
 });
 
 test('map handling of undefined values', () => {
-	const map = new ReactiveMap();
+	const map = new SvelteMap();
 
 	const log: any = [];
 
@@ -208,7 +208,7 @@ test('map handling of undefined values', () => {
 });
 
 test('not invoking reactivity when value is not in the map after changes', () => {
-	const map = new ReactiveMap([[1, 1]]);
+	const map = new SvelteMap([[1, 1]]);
 
 	const log: any = [];
 
@@ -236,5 +236,5 @@ test('not invoking reactivity when value is not in the map after changes', () =>
 });
 
 test('Map.instanceOf', () => {
-	assert.equal(new ReactiveMap() instanceof Map, true);
+	assert.equal(new SvelteMap() instanceof Map, true);
 });

packages/svelte/src/reactivity/set.js

@@ -12,7 +12,7 @@ var inited = false;
  * @template T
  * @extends {Set<T>}
  */
-export class ReactiveSet extends Set {
+export class SvelteSet extends Set {
 	/** @type {Map<T, import('#client').Source<boolean>>} */
 	#sources = new Map();
 	#version = source(0);
@@ -41,7 +41,7 @@ export class ReactiveSet extends Set {
 	#init() {
 		inited = true;
 
-		var proto = ReactiveSet.prototype;
+		var proto = SvelteSet.prototype;
 		var set_proto = Set.prototype;
 
 		for (const method of read_methods) {
@@ -59,7 +59,7 @@ export class ReactiveSet extends Set {
 				get(this.#version);
 				// @ts-ignore
 				var set = /** @type {Set<T>} */ (set_proto[method].apply(this, v));
-				return new ReactiveSet(set);
+				return new SvelteSet(set);
 			};
 		}
 	}

packages/svelte/src/reactivity/set.test.ts

@@ -1,10 +1,10 @@
 import { render_effect, effect_root } from '../internal/client/reactivity/effects.js';
 import { flushSync } from '../index-client.js';
-import { ReactiveSet } from './set.js';
+import { SvelteSet } from './set.js';
 import { assert, test } from 'vitest';
 
 test('set.values()', () => {
-	const set = new ReactiveSet([1, 2, 3, 4, 5]);
+	const set = new SvelteSet([1, 2, 3, 4, 5]);
 
 	const log: any = [];
 
@@ -36,7 +36,7 @@ test('set.values()', () => {
 });
 
 test('set.has(...)', () => {
-	const set = new ReactiveSet([1, 2, 3]);
+	const set = new SvelteSet([1, 2, 3]);
 
 	const log: any = [];
 
@@ -79,7 +79,7 @@ test('set.has(...)', () => {
 });
 
 test('set.delete(...)', () => {
-	const set = new ReactiveSet([1, 2, 3]);
+	const set = new SvelteSet([1, 2, 3]);
 
 	assert.equal(set.delete(3), true);
 	assert.equal(set.delete(3), false);
@@ -88,7 +88,7 @@ test('set.delete(...)', () => {
 });
 
 test('set.forEach()', () => {
-	const set = new ReactiveSet([1, 2, 3, 4, 5]);
+	const set = new SvelteSet([1, 2, 3, 4, 5]);
 
 	const log: any = [];
 
@@ -108,7 +108,7 @@ test('set.forEach()', () => {
 });
 
 test('not invoking reactivity when value is not in the set after changes', () => {
-	const set = new ReactiveSet([1, 2]);
+	const set = new SvelteSet([1, 2]);
 
 	const log: any = [];
 
@@ -155,5 +155,5 @@ test('not invoking reactivity when value is not in the set after changes', () =>
 });
 
 test('Set.instanceOf', () => {
-	assert.equal(new ReactiveSet() instanceof Set, true);
+	assert.equal(new SvelteSet() instanceof Set, true);
 });

packages/svelte/src/reactivity/url.js

@@ -4,15 +4,15 @@ import { increment } from './utils.js';
 
 const REPLACE = Symbol();
 
-export class ReactiveURL extends URL {
+export class SvelteURL extends URL {
 	#protocol = source(super.protocol);
 	#username = source(super.username);
 	#password = source(super.password);
 	#hostname = source(super.hostname);
 	#port = source(super.port);
 	#pathname = source(super.pathname);
 	#hash = source(super.hash);
-	#searchParams = new ReactiveURLSearchParams();
+	#searchParams = new SvelteURLSearchParams();
 
 	/**
 	 * @param {string | URL} url
@@ -153,7 +153,7 @@ export class ReactiveURL extends URL {
 	}
 }
 
-export class ReactiveURLSearchParams extends URLSearchParams {
+export class SvelteURLSearchParams extends URLSearchParams {
 	#version = source(0);
 
 	/**

packages/svelte/src/reactivity/url.test.ts

@@ -1,10 +1,10 @@
 import { render_effect, effect_root } from '../internal/client/reactivity/effects.js';
 import { flushSync } from '../index-client.js';
-import { ReactiveURL, ReactiveURLSearchParams } from './url.js';
+import { SvelteURL, SvelteURLSearchParams } from './url.js';
 import { assert, test } from 'vitest';
 
 test('url.hash', () => {
-	const url = new ReactiveURL('http://google.com');
+	const url = new SvelteURL('http://google.com');
 	const log: any = [];
 
 	const cleanup = effect_root(() => {
@@ -32,7 +32,7 @@ test('url.hash', () => {
 });
 
 test('url.searchParams', () => {
-	const url = new ReactiveURL('https://svelte.dev?foo=bar&t=123');
+	const url = new SvelteURL('https://svelte.dev?foo=bar&t=123');
 	const log: any = [];
 
 	const cleanup = effect_root(() => {
@@ -78,7 +78,7 @@ test('url.searchParams', () => {
 });
 
 test('URLSearchParams', () => {
-	const params = new ReactiveURLSearchParams();
+	const params = new SvelteURLSearchParams();
 	const log: any = [];
 
 	const cleanup = effect_root(() => {