only do it for bind:this

Author: dummdidumm

packages/svelte/src/compiler/phases/3-transform/client/visitors/template.js

@@ -2830,7 +2830,14 @@ export const template_visitors = {
 
 		if (
 			expression.type === 'MemberExpression' &&
-			(!property || property.bidirectional) &&
+			(node.name !== 'this' ||
+				path.some(
+					({ type }) =>
+						type === 'IfBlock' ||
+						type === 'EachBlock' ||
+						type === 'AwaitBlock' ||
+						type === 'KeyBlock'
+				)) &&
 			context.state.options.dev &&
 			context.state.analysis.runes
 		) {

packages/svelte/tests/runtime-runes/samples/binding-property-static/_config.js

@@ -7,10 +7,11 @@ export default test({
 
 	async test({ assert, warnings }) {
 		assert.deepEqual(warnings, [
-			`\`bind:value={pojo.value}\` (main.svelte:50:7) is binding to a non-reactive property`,
-			`\`bind:value={frozen.value}\` (main.svelte:51:7) is binding to a non-reactive property`,
-			`\`bind:value={pojo.value}\` (main.svelte:52:7) is binding to a non-reactive property`,
-			`\`bind:value={frozen.value}\` (main.svelte:53:7) is binding to a non-reactive property`
+			'`bind:value={pojo.value}` (main.svelte:50:7) is binding to a non-reactive property',
+			'`bind:value={frozen.value}` (main.svelte:51:7) is binding to a non-reactive property',
+			'`bind:value={pojo.value}` (main.svelte:52:7) is binding to a non-reactive property',
+			'`bind:value={frozen.value}` (main.svelte:53:7) is binding to a non-reactive property',
+			'`bind:this={pojo.value}` (main.svelte:55:6) is binding to a non-reactive property'
 		]);
 	}
 });

packages/svelte/tests/runtime-runes/samples/binding-property-static/main.svelte

@@ -51,39 +51,15 @@
 <input bind:value={frozen.value} />
 <Child bind:value={pojo.value} />
 <Child bind:value={frozen.value} />
+{#if value}
+	<div bind:this={pojo.value}></div>
+{/if}
 
-<!-- should not warn (because reactive value) -->
+<!-- should not warn -->
 <input bind:value={reactive.value} />
 <input bind:value={accessors.value} />
 <input bind:value={proxy.value} />
 <Child bind:value={reactive.value} />
 <Child bind:value={accessors.value} />
 <Child bind:value={proxy.value} />
-
-<!-- should not warn (because one-way binding) -->
-<svelte:window
-	bind:innerHeight={pojo.value}
-	bind:innerWidth={pojo.value}
-	bind:outerHeight={pojo.value}
-	bind:outerWidth={pojo.value}
-	bind:online={pojo.value}
-	bind:devicePixelRatio={pojo.value}
-/>
-<svelte:document
-	bind:activeElement={pojo.value}
-	bind:fullscreenElement={pojo.value}
-	bind:pointerLockElement={pojo.value}
-	bind:visibilityState={pojo.value}
-/>
-<!-- can't test size bindings because it's not available in JSDom https://github.com/jsdom/jsdom/issues/3368 -->
 <div bind:this={pojo.value}></div>
-<video
-	bind:duration={pojo.value}
-	bind:buffered={pojo.value}
-	bind:played={pojo.value}
-	bind:seeking={pojo.value}
-	bind:readyState={pojo.value}
-	bind:videoHeight={pojo.value}
-	bind:videoWidth={pojo.value}
-></video>
-<img bind:naturalHeight={pojo.value} bind:naturalWidth={pojo.value} />