Skip to content

Commit 5b08b50

Browse files
committed
fix: fixed some broken tests related with the new way of dealing with old and new event-handling syntaxes
1 parent ecd6c21 commit 5b08b50

File tree

12 files changed

+61
-27
lines changed

12 files changed

+61
-27
lines changed

packages/svelte/tests/runtime-runes/samples/event-attribute-delegation-2/main.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div on:click={(e) => { console.log('clicked div') }}>
1+
<div onclick={(e) => { console.log('clicked div') }}>
22
<button onclick={(e) => { console.log('clicked button'); e.stopPropagation() }}>
33
Button
44
</button>
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<script>
2+
const { children, ...props } = $props();
3+
</script>
4+
5+
<div {...props} on:click>
6+
{@render children()}
7+
</div>
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
<script>
2+
import Component from "./Component.svelte";
23
import Sub from "./sub.svelte";
34
</script>
45

56
<svelte:window onclick="{() => console.log('window main')}" />
67
<svelte:document onclick="{() => console.log('document main')}" />
78

8-
<div on:click={() => console.log('div main 1')} on:click={() => console.log('div main 2')}>
9+
<Component on:click={() => console.log('div main 1')} on:click={() => console.log('div main 2')}>
910
<button onclick={() => console.log('button main')}>main</button>
10-
</div>
11+
</Component>
1112

1213
<Sub />
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<script>
2+
const { children, ...props } = $props();
3+
</script>
4+
5+
<button {...props} on:click>
6+
{@render children()}
7+
</button>
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<script>
2+
const { children, ...props } = $props();
3+
</script>
4+
5+
<div {...props} on:click>
6+
{@render children()}
7+
</div>
Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
1-
<div onclick={() => console.log('outer div onclick')}>
2-
<div on:click={() => console.log('inner div on:click')}>
3-
<button onclick={() => console.log('button onclick')} on:click={() => console.log('button on:click')}>main</button>
4-
</div>
5-
</div>
1+
<script>
2+
import Component from "./Component.svelte";
3+
import Button from "./Button.svelte";
4+
</script>
5+
6+
<Component onclick={() => console.log('outer div onclick')}>
7+
<Component on:click={() => console.log('inner div on:click')}>
8+
<Button onclick={() => console.log('button onclick')} on:click={() => console.log('button on:click')}>main</Button>
9+
</Component>
10+
</Component>
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<script>
2+
const { children, ...props } = $props();
3+
</script>
4+
5+
<button {...props} on:click>
6+
{@render children()}
7+
</button>
Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,22 @@
11
<script>
2+
import Button from './Button.svelte';
23
let text = $state('click me');
34
let text2 = $state('');
45
let spread = { onclick: () => text = 'click spread' };
56
</script>
67

7-
<button onclick={() => text = 'click onclick'} {...spread}>
8+
<Button onclick={() => text = 'click onclick'} {...spread}>
89
{text}
9-
</button>
10+
</Button>
1011

11-
<button {...spread} onclick={() => text = 'click onclick'}>
12+
<Button {...spread} onclick={() => text = 'click onclick'}>
1213
{text}
13-
</button>
14+
</Button>
1415

15-
<button onclick={() => text = 'click onclick'} {...spread} on:click={() => text2 = '!'}>
16+
<Button onclick={() => text = 'click onclick'} {...spread} on:click={() => text2 = '!'}>
1617
{text}{text2}
17-
</button>
18+
</Button>
1819

19-
<button on:click={() => text2 = '?'} {...spread} onclick={() => text = 'click onclick'}>
20+
<Button on:click={() => text2 = '?'} {...spread} onclick={() => text = 'click onclick'}>
2021
{text}{text2}
21-
</button>
22+
</Button>

packages/svelte/tests/validator/samples/a11y-click-events-have-key-events/input.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
<!-- svelte-ignore a11y_no_noninteractive_element_interactions -->
2626
<footer on:click={noop}></footer>
2727
<!-- svelte-ignore a11y_no_noninteractive_element_interactions -->
28-
<footer onclick={noop}></footer>
28+
<footer on:click={noop}></footer>
2929

3030
<!-- should not warn -->
3131
<div class="foo"></div>
@@ -68,7 +68,7 @@
6868
<div on:click={noop} role="presentation"></div>
6969
<div on:click={noop} role="none"></div>
7070
<div on:click={noop} role={dynamicRole}></div>
71-
<div onclick={noop} role={dynamicRole}></div>
71+
<div on:click={noop} role={dynamicRole}></div>
7272

7373
<!-- svelte-ignore a11y_no_static_element_interactions -->
7474
<svelte:element this={Math.random() ? 'button' : 'div'} on:click={noop} />

packages/svelte/tests/validator/samples/a11y-click-events-have-key-events/warnings.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@
9292
},
9393
"end": {
9494
"line": 28,
95-
"column": 32
95+
"column": 33
9696
}
9797
}
9898
]

0 commit comments

Comments
 (0)