fix: correctly validate <svelte:component> with bind:this (#12368)

Rich-Harris · web-flow · commit 1d8d38c8bdfe · 2024-07-09T14:26:45.000-04:00
diff --git a/.changeset/witty-sloths-impress.md b/.changeset/witty-sloths-impress.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: correctly validate `<svelte:component>` with `bind:this`
diff --git a/packages/svelte/src/internal/client/dom/elements/bindings/this.js b/packages/svelte/src/internal/client/dom/elements/bindings/this.js
@@ -56,4 +56,6 @@ export function bind_this(element_or_component = {}, update, get_value, get_part
 			});
 		};
 	});
+
+	return element_or_component;
 }
diff --git a/packages/svelte/src/internal/client/validate.js b/packages/svelte/src/internal/client/validate.js
@@ -12,8 +12,9 @@ function is_void(tag) {
 }
 
 /**
- * @param {() => any} component_fn
- * @returns {any}
+ * @template Component
+ * @param {() => Component} component_fn
+ * @returns {Component}
  */
 export function validate_dynamic_component(component_fn) {
 	try {

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'svelte': patch
 +---
++
 +fix: correctly validate `<svelte:component>` with `bind:this`
Original file line number	Diff line number	Diff line change
`@@ -56,4 +56,6 @@ export function bind_this(element_or_component = {}, update, get_value, get_part`
`56`	`56`	`});`
`57`	`57`	`};`
`58`	`58`	`});`
	`59`	`+`
	`60`	`+ return element_or_component;`
`59`	`61`	`}`