Skip to content

Update index.d.ts #8956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 9, 2023
Merged

Update index.d.ts #8956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b649746
Update index.d.ts
0gust1 Feb 8, 2023
eaf0986
Update index.d.ts
0gust1 Feb 8, 2023
34fed52
Update packages/kit/types/index.d.ts
Rich-Harris Feb 9, 2023
aa54630
changeset
Rich-Harris Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/chilly-otters-act.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

docs: clarify that `version.name` should be deterministic
3 changes: 1 addition & 2 deletions packages/kit/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,8 +542,7 @@ export interface KitConfig {
*/
version?: {
/**
* The current app version string.
* @default Date.now().toString()
* The current app version string. If specified, this must be deterministic (e.g. a commit ref rather than `Math.random()` or Date.now().toString()`), otherwise defaults to a timestamp of the build
*/
name?: string;
/**
Expand Down