Skip to content

re-enable skipped tests #7079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2022
Merged

re-enable skipped tests #7079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions packages/kit/test/apps/options/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,13 @@ test.describe('base path', () => {
);
});

// TODO re-enable these once we upgrade to Vite 3
// https://github.com/sveltejs/kit/pull/4891#issuecomment-1125471630
test.skip('sets_paths', async ({ page }) => {
test('sets_paths', async ({ page }) => {
await page.goto('/path-base/base/');
expect(await page.textContent('[data-source="base"]')).toBe('/path-base');
expect(await page.textContent('[data-source="assets"]')).toBe('/_svelte_kit_assets');
});

test.skip('loads javascript', async ({ page, javaScriptEnabled }) => {
test('loads javascript', async ({ page, javaScriptEnabled }) => {
await page.goto('/path-base/base/');
expect(await page.textContent('button')).toBe('clicks: 0');

Expand All @@ -42,7 +40,7 @@ test.describe('base path', () => {
}
});

test.skip('loads CSS', async ({ page }) => {
test('loads CSS', async ({ page }) => {
await page.goto('/path-base/base/');
expect(
await page.evaluate(() => {
Expand All @@ -52,7 +50,7 @@ test.describe('base path', () => {
).toBe('rgb(255, 0, 0)');
});

test.skip('inlines CSS', async ({ page, javaScriptEnabled }) => {
test('inlines CSS', async ({ page, javaScriptEnabled }) => {
await page.goto('/path-base/base/');
if (process.env.DEV) {
const ssr_style = await page.evaluate(() => document.querySelector('style[data-sveltekit]'));
Expand All @@ -78,7 +76,7 @@ test.describe('base path', () => {
}
});

test.skip('sets params correctly', async ({ page, clicknav }) => {
test('sets params correctly', async ({ page, clicknav }) => {
await page.goto('/path-base/base/one');

expect(await page.textContent('h2')).toBe('one');
Expand Down