From 1dd2badaaa20b9be7ea658878bd38ca9557c2eac Mon Sep 17 00:00:00 2001 From: Ignatius Bagus Date: Fri, 27 Aug 2021 17:55:34 +0700 Subject: [PATCH 1/2] add kit to noExternal --- packages/kit/src/core/build/index.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/kit/src/core/build/index.js b/packages/kit/src/core/build/index.js index 75f91ac5808b..45c86e13477b 100644 --- a/packages/kit/src/core/build/index.js +++ b/packages/kit/src/core/build/index.js @@ -488,10 +488,12 @@ async function build_server( } }, ssr: { - // note to self: this _might_ need to be ['svelte', '@sveltejs/kit', ...get_no_external()] - // but I'm honestly not sure. roll with this for now and see if it's ok - // @ts-expect-error - ssr is considered in alpha, so not yet exposed by Vite - noExternal: [...((vite_config.ssr && vite_config.ssr.noExternal) || []), ...svelte_packages] + noExternal: [ + '@sveltejs/kit', + // @ts-expect-error - ssr is considered in alpha, so not yet exposed by Vite + ...((vite_config.ssr && vite_config.ssr.noExternal) || []), + ...svelte_packages + ] } }); From 0dd95dd09b11fc6a638b05484156c3323dca4397 Mon Sep 17 00:00:00 2001 From: Ignatius Bagus Date: Fri, 27 Aug 2021 18:03:00 +0700 Subject: [PATCH 2/2] add changeset --- .changeset/short-emus-juggle.md | 5 +++++ packages/kit/src/core/build/index.js | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/short-emus-juggle.md diff --git a/.changeset/short-emus-juggle.md b/.changeset/short-emus-juggle.md new file mode 100644 index 000000000000..8a8106651e77 --- /dev/null +++ b/.changeset/short-emus-juggle.md @@ -0,0 +1,5 @@ +--- +'@sveltejs/kit': patch +--- + +Add `@sveltejs/kit` to noExternal to resolve hooks module in dev server diff --git a/packages/kit/src/core/build/index.js b/packages/kit/src/core/build/index.js index 45c86e13477b..a169e9d2504e 100644 --- a/packages/kit/src/core/build/index.js +++ b/packages/kit/src/core/build/index.js @@ -489,7 +489,7 @@ async function build_server( }, ssr: { noExternal: [ - '@sveltejs/kit', + '@sveltejs/kit', // TODO: see https://github.com/vitejs/vite/issues/3953 // @ts-expect-error - ssr is considered in alpha, so not yet exposed by Vite ...((vite_config.ssr && vite_config.ssr.noExternal) || []), ...svelte_packages