fix: prevent TypeError in serialize_refreshes when state.refreshes is null #14402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When calling
redirect()in remote functions, SvelteKit crashes with:This happens because:
redirect(302, '/some-path')Redirectexception and tries to create a JSON responseserialize_refreshes()to handle any pending refreshesserialize_refreshesassumesstate.refreshesis always an object, but it can benull/undefinedObject.keys(refreshes)throws whenrefreshesisnull/undefinedSolution
Add a fallback to an empty object when
state.refreshesisnull/undefined:Testing
Reproduction
Impact
This is a bug fix that allows remote functions to use redirects as intended, without breaking existing functionality.