Skip to content

Conversation

@dummdidumm
Copy link
Member

Fixes #12880, relies on sveltejs/svelte#13929


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: c591d44

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-migrate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ghostdevv ghostdevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah

Error: packages/migrate check: migrations/svelte-5/index.js(175,61): error TS2353: Object literal may only specify known properties, and 'use_ts' does not exist in type '{ filename?: string | undefined; }'.

@dummdidumm dummdidumm merged commit 48f0201 into main Oct 31, 2024
10 checks passed
@dummdidumm dummdidumm deleted the migration-prefer-ts-if-tsconfig branch October 31, 2024 21:31
@github-actions github-actions bot mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--typescript flag / disable JSDoc

4 participants