Skip to content

Conversation

@teemingc
Copy link
Member

@teemingc teemingc commented Oct 23, 2024

fixes #12582
fixes #12188

Replaces #10032 by using location.replace to allow the browser to handle hash link behaviour instead #10856 (comment)

This PR ensures that clicking on a hash link with the reload option avoids the usual behaviour of thinking the page will reload and instead allows it to be handled as if the option wasn't enabled (hash links on the same page never reload the page).

It also fixes a behaviour where an element doesn't get focused when clicking on the hash link more than once.

TODO:

  • fix behaviour where clicking a hash link twice doesn't focus the input

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2024

🦋 Changeset detected

Latest commit: fd0a3aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@teemingc teemingc changed the title fix: defer to browser when clicking hash links fix: defer when clicking hash links with data-sveltekit-reload Oct 23, 2024
@teemingc teemingc changed the title fix: defer when clicking hash links with data-sveltekit-reload fix: do not reload when clicking hash links with data-sveltekit-reload Oct 23, 2024
@teemingc teemingc changed the title fix: do not reload when clicking hash links with data-sveltekit-reload fix: defer when clicking hash links with data-sveltekit-reload Oct 23, 2024
@teemingc teemingc marked this pull request as draft October 23, 2024 09:14
@teemingc teemingc marked this pull request as ready for review October 23, 2024 09:18
@teemingc teemingc requested a review from dummdidumm October 25, 2024 13:53
@dummdidumm dummdidumm merged commit 5006435 into main Oct 28, 2024
10 checks passed
@dummdidumm dummdidumm deleted the fix-same-hash-focus branch October 28, 2024 09:33
@github-actions github-actions bot mentioned this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

data-sveltekit-reload href="#id" blocks subsequent beforeNavigate Can't navigate back from a path with hash and data-sveltekit-reload

3 participants