fix: ensure environment setup is in its own chunk (#14441)

* fix: ensure environment setup is in its own chunk

This way you cannot run into initialization order issues where e.g. some remote function uses environment variables before they're set

Fixes #14439

* fix test

Author: dummdidumm

.changeset/busy-pumas-tap.md

@@ -0,0 +1,5 @@
+---
+'@sveltejs/kit': patch
+---
+
+fix: ensure environment setup is in its own chunk

packages/kit/src/exports/vite/index.js

@@ -682,9 +682,13 @@ async function kit({ svelte_config }) {
 			config.build.rollupOptions.output = {
 				...config.build.rollupOptions.output,
 				manualChunks(id, meta) {
+					// Prevent core runtime and env from ending up in a remote chunk, which could break because of initialization order
 					if (id === `${runtime_directory}/app/server/index.js`) {
 						return 'app-server';
 					}
+					if (id === `${runtime_directory}/shared-server.js`) {
+						return 'app-shared-server';
+					}
 
 					// Check if this is a *.remote.ts file
 					if (svelte_config.kit.moduleExtensions.some((ext) => id.endsWith(`.remote${ext}`))) {

packages/kit/test/apps/basics/src/routes/remote/+page.svelte

@@ -9,11 +9,14 @@
 		set_count_server_set,
 		resolve_deferreds
 	} from './query-command.remote.js';
+	import { q } from './accessing-env.remote';
 
 	let { data } = $props();
 
 	let command_result = $state(null);
-	let release;
+
+	// we just want it not to be treeshaken away
+	q;
 
 	const count = browser ? get_count() : null; // so that we get a remote request in the browser
 </script>

packages/kit/test/apps/basics/src/routes/remote/accessing-env.remote.js

@@ -1,8 +1,14 @@
+import { query } from '$app/server';
 import { env } from '$env/dynamic/private';
 import { env as public_env } from '$env/dynamic/public';
 
 if (!env.PRIVATE_DYNAMIC || !public_env.PUBLIC_DYNAMIC) {
 	// This checks that dynamic env vars are available when prerendering remote functions
 	// https://github.com/sveltejs/kit/pull/14219
+	// and are not in the same chunk as this one
+	// https://github.com/sveltejs/kit/issues/14439
 	throw new Error('Dynamic environment variables are not set up correctly');
 }
+
+// placeholder query that needs to be imported/used elsewhere so that bundling/chunking would include env setup if not setup correctly
+export const q = query(() => {});