[fix] Process symlinked routes (#4957)

* [fix] Process sym-linked routes

* Revert to fs.statSync

* Update packages/kit/src/core/sync/create_manifest_data/index.js

Co-authored-by: Maurício Kishi <[email protected]>

* reword sym-linked to symlinked

* skip symlinks tests when unsupported

Co-authored-by: Maurício Kishi <[email protected]>
Co-authored-by: mrkishi <[email protected]>

Author: mikenikles

.changeset/few-cobras-switch.md

@@ -0,0 +1,5 @@
+---
+'@sveltejs/kit': patch
+---
+
+Allow symlinked directories in the routes folder

packages/kit/src/core/sync/create_manifest_data/index.js

@@ -426,8 +426,8 @@ function count_occurrences(needle, haystack) {
  * @param {string[]} [files]
  */
 function list_files(dir, path = '', files = []) {
-	fs.readdirSync(dir, { withFileTypes: true })
-		.sort(({ name: a }, { name: b }) => {
 			// sort each directory in (__layout, __error, everything else) order
 			// so that we can trace layouts/errors immediately
 
@@ -444,10 +444,12 @@ function list_files(dir, path = '', files = []) {
 			return a < b ? -1 : 1;
 		})
 		.forEach((file) => {
-			const joined = path ? `${path}/${file.name}` : file.name;
+			const stats = fs.statSync(full);
+			const joined = path ? `${path}/${file}` : file;
 
-			if (file.isDirectory()) {
-				list_files(`${dir}/${file.name}`, joined, files);
 			} else {
 				files.push(joined);
 			}

packages/kit/src/core/sync/create_manifest_data/index.spec.js

@@ -1,3 +1,4 @@
+import fs from 'fs';
 import path from 'path';
 import { fileURLToPath } from 'url';
 import { test } from 'uvu';
@@ -95,6 +96,43 @@ test('creates routes', () => {
 	]);
 });
 
+const symlink_survived_git = fs
+	.statSync(path.join(cwd, 'samples/symlinks/routes/foo'))
+	.isSymbolicLink();
+
+const test_symlinks = symlink_survived_git ? test : test.skip;
+
+test_symlinks('creates symlinked routes', () => {
+	const { components, routes } = create('samples/symlinks/routes');
+
+	const index = 'samples/symlinks/routes/index.svelte';
+	const symlinked_index = 'samples/symlinks/routes/foo/index.svelte';
+
+	assert.equal(components, [default_layout, default_error, symlinked_index, index]);
+
+	assert.equal(routes, [
+		{
+			type: 'page',
+			id: '',
+			pattern: /^\/$/,
+			path: '/',
+			shadow: null,
+			a: [default_layout, index],
+			b: [default_error]
+		},
+
+		{
+			type: 'page',
+			id: 'foo',
+			pattern: /^\/foo\/?$/,
+			path: '/foo',
+			shadow: null,
+			a: [default_layout, symlinked_index],
+			b: [default_error]
+		}
+	]);
+});
+
 test('creates routes with layout', () => {
 	const { components, routes } = create('samples/basic-layout');
 

packages/kit/src/core/sync/create_manifest_data/test/samples/symlinks/bar/index.svelte

@@ -0,0 +1 @@
+../bar