Skip to content

Commit e21892b

Browse files
authored
[fix] explicitly add kit to ssr.noExternal (#2306)
1 parent 8c53262 commit e21892b

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

.changeset/short-emus-juggle.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@sveltejs/kit': patch
3+
---
4+
5+
Add `@sveltejs/kit` to noExternal to resolve hooks module in dev server

packages/kit/src/core/build/index.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -488,10 +488,12 @@ async function build_server(
488488
}
489489
},
490490
ssr: {
491-
// note to self: this _might_ need to be ['svelte', '@sveltejs/kit', ...get_no_external()]
492-
// but I'm honestly not sure. roll with this for now and see if it's ok
493-
// @ts-expect-error - ssr is considered in alpha, so not yet exposed by Vite
494-
noExternal: [...((vite_config.ssr && vite_config.ssr.noExternal) || []), ...svelte_packages]
491+
noExternal: [
492+
'@sveltejs/kit', // TODO: see https://github.com/vitejs/vite/issues/3953
493+
// @ts-expect-error - ssr is considered in alpha, so not yet exposed by Vite
494+
...((vite_config.ssr && vite_config.ssr.noExternal) || []),
495+
...svelte_packages
496+
]
495497
}
496498
});
497499

0 commit comments

Comments
 (0)