fix: lint pipeline automatically formats files, misses errors in CI (#5021)

elliott-with-the-longest-name-on-github · mrkishi · web-flow · commit dacdfb061ed5 · 2022-05-23T10:03:00.000-04:00
* fix: Incorrectly-cached formatting

* stop formatting files before linting

* format changes in master

* rename the `autolint` script to `precommit`

Co-authored-by: mrkishi &lt;mauriciokishi@gmail.com&gt;
diff --git a/package.json b/package.json
@@ -9,6 +9,7 @@
 		"check": "turbo run check",
 		"lint": "turbo run lint",
 		"format": "turbo run format",
+		"precommit": "turbo run precommit",
 		"release": "changeset publish"
 	},
 	"repository": {
diff --git a/packages/kit/test/apps/basics/src/routes/load/window-fetch/data.json.js b/packages/kit/test/apps/basics/src/routes/load/window-fetch/data.json.js
@@ -5,4 +5,4 @@ export function get() {
 			answer: 42
 		}
 	};
-}
+}
diff --git a/packages/kit/test/prerendering/paths-base/svelte.config.js b/packages/kit/test/prerendering/paths-base/svelte.config.js
@@ -7,7 +7,7 @@ const config = {
 		adapter: adapter(),
 
 		paths: {
-			base: '/path-base',
+			base: '/path-base'
 		},
 
 		prerender: {
diff --git a/turbo.json b/turbo.json
@@ -25,7 +25,10 @@
 			"outputs": []
 		},
 		"lint": {
-			"dependsOn": ["format"],
+			"outputs": []
+		},
+		"precommit": {
+			"dependsOn": ["format", "lint"],
 			"outputs": []
 		},
 		"dev": {

Original file line number	Original file line	Diff line number	Diff line change
`@@ -9,6 +9,7 @@`
`9`	`"check": "turbo run check",`	`9`	`"check": "turbo run check",`
`10`	`"lint": "turbo run lint",`	`10`	`"lint": "turbo run lint",`
`11`	`"format": "turbo run format",`	`11`	`"format": "turbo run format",`
		`12`	`+ "precommit": "turbo run precommit",`
`12`	`"release": "changeset publish"`	`13`	`"release": "changeset publish"`
`13`	`},`	`14`	`},`
`14`	`"repository": {`	`15`	`"repository": {`
Original file line number	Original file line	Diff line number	Diff line change
`@@ -5,4 +5,4 @@ export function get() {`
`5`	`answer: 42`	`5`	`answer: 42`
`6`	`}`	`6`	`}`
`7`	`};`	`7`	`};`
`8`	`-}`	`8`	`+}`
Original file line number	Original file line	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ const config = {`
`7`	`adapter: adapter(),`	`7`	`adapter: adapter(),`
`8`		`8`
`9`	`paths: {`	`9`	`paths: {`
`10`	`- base: '/path-base',`	`10`	`+ base: '/path-base'`
`11`	`},`	`11`	`},`
`12`		`12`
`13`	`prerender: {`	`13`	`prerender: {`
Original file line number	Original file line	Diff line number	Diff line change
`@@ -25,7 +25,10 @@`
`25`	`"outputs": []`	`25`	`"outputs": []`
`26`	`},`	`26`	`},`
`27`	`"lint": {`	`27`	`"lint": {`
`28`	`- "dependsOn": ["format"],`	`28`	`+ "outputs": []`
		`29`	`+ },`
		`30`	`+ "precommit": {`
		`31`	`+ "dependsOn": ["format", "lint"],`
`29`	`"outputs": []`	`32`	`"outputs": []`
`30`	`},`	`33`	`},`
`31`	`"dev": {`	`34`	`"dev": {`