fix: Prevent crawling empty urls from <img src=""> (#8883)

bfanger · dummdidumm · web-flow · commit 97d68b1381c1 · 2023-02-06T15:52:51.000+01:00
The empty src was crawled as a relative url.
On `/page/about` this would route to `/page/` which could 404

---------

Co-authored-by: Simon H &lt;5968653+dummdidumm@users.noreply.github.com&gt;
diff --git a/.changeset/lucky-tables-jam.md b/.changeset/lucky-tables-jam.md
@@ -0,0 +1,5 @@
+---
+'@sveltejs/kit': patch
+---
+
+fix: prevent crawling empty urls (`<img src="">`)
diff --git a/packages/kit/src/core/postbuild/crawl.js b/packages/kit/src/core/postbuild/crawl.js
@@ -165,7 +165,7 @@ export function crawl(html) {
 							} else if (name === 'rel') {
 								rel = value;
 							} else if (name === 'src') {
-								hrefs.push(value);
+								if (value) hrefs.push(value);
 							} else if (name === 'srcset') {
 								const candidates = [];
 								let insideURL = true;
@@ -183,7 +183,7 @@ export function crawl(html) {
 								candidates.push(value);
 								for (const candidate of candidates) {
 									const src = candidate.split(WHITESPACE)[0];
-									hrefs.push(src);
+									if (src) hrefs.push(src);
 								}
 							}
 						} else {
diff --git a/packages/kit/src/core/postbuild/fixtures/basic-src/input.html b/packages/kit/src/core/postbuild/fixtures/basic-src/input.html
@@ -3,5 +3,6 @@
 	<head></head>
 	<body>
 		<img alt="A potato" src="/potato.jpg" />
+		<img alt="empty" src="" />
 	</body>
 </html>

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@sveltejs/kit': patch
 +---
++
 +fix: prevent crawling empty urls (`<img src="">`)