chore: reduce windows coverage (#8632)

* reduce windows coverage

* test build errors

* cross-browser -> cross-platform

* oops

* Update .github/workflows/ci.yml

Co-authored-by: Ben McCann <[email protected]>

Co-authored-by: Ben McCann <[email protected]>

Author: Rich-Harris

.github/workflows/ci.yml

@@ -42,9 +42,6 @@ jobs:
           - node-version: 16
             os: ubuntu-latest
             e2e-browser: 'chromium'
-          - node-version: 16
-            os: windows-latest
-            e2e-browser: 'chromium'
           - node-version: 18
             os: ubuntu-latest
             e2e-browser: 'chromium'
@@ -81,7 +78,7 @@ jobs:
       matrix:
         include:
           - node-version: 16
-            os: ubuntu-latest
+            os: windows-2019 # slowness reported on newer versions https://github.com/actions/runner-images/issues/5166
             e2e-browser: 'firefox'
           - node-version: 16
             os: macOS-latest
@@ -99,15 +96,15 @@ jobs:
           cache: pnpm
       - run: pnpm install --frozen-lockfile
       - run: pnpm playwright install ${{ matrix.e2e-browser }}
-      - run: pnpm test:cross-browser
+      - run: pnpm test:cross-platform
       - name: Archive test results
         if: failure()
         shell: bash
-        run: find packages -type d -name test-results -not -empty | tar -czf test-results-cross-browser.tar.gz --files-from=-
+        run: find packages -type d -name test-results -not -empty | tar -czf test-results-cross-platform.tar.gz --files-from=-
       - name: Upload test results
         if: failure()
         uses: actions/upload-artifact@v3
         with:
           retention-days: 3
-          name: test-failure-cross-browser-${{ github.run_id }}-${{ matrix.os }}-${{ matrix.node-version }}-${{ matrix.e2e-browser }}
-          path: test-results-cross-browser.tar.gz
+          name: test-failure-cross-platform-${{ github.run_id }}-${{ matrix.os }}-${{ matrix.node-version }}-${{ matrix.e2e-browser }}
+          path: test-results-cross-platform.tar.gz

package.json

@@ -5,7 +5,7 @@
 	"private": true,
 	"scripts": {
 		"test": "turbo run test --filter=./packages/*",
-		"test:cross-browser": "turbo run test:cross-browser --filter=./packages/*",
+		"test:cross-platform": "turbo run test:cross-platform --filter=./packages/*",
 		"test:vite-ecosystem-ci": "pnpm test --dir packages/kit",
 		"check": "turbo run check",
 		"lint": "turbo run lint",

packages/kit/package.json

@@ -63,7 +63,7 @@
 		"format": "pnpm lint --write",
 		"test": "pnpm test:unit && pnpm test:integration",
 		"test:integration": "pnpm -r --workspace-concurrency 1 --filter=\"./test/**\" test",
-		"test:cross-browser": "pnpm -r --workspace-concurrency 1 --filter=\"./test/**\" test:cross-browser",
+		"test:cross-platform": "pnpm test:unit && pnpm -r --workspace-concurrency 1 --filter=\"./test/**\" test:cross-platform",
 		"test:unit": "uvu src \"(spec\\.js|test[\\\\/]index\\.js)\"",
 		"postinstall": "node postinstall.js"
 	},

packages/kit/test/apps/basics/package.json

@@ -10,9 +10,9 @@
 		"test": "node test/setup.js && pnpm test:dev && pnpm test:build",
 		"test:dev": "rimraf test/errors.json && cross-env DEV=true playwright test",
 		"test:build": "rimraf test/errors.json && playwright test",
-		"test:cross-browser": "npm run test:cross-browser:dev && npm run test:cross-browser:build",
-		"test:cross-browser:dev": "node test/setup.js && rimraf test/errors.json && cross-env DEV=true playwright test test/cross-browser/",
-		"test:cross-browser:build": "node test/setup.js && rimraf test/errors.json && playwright test test/cross-browser/"
+		"test:cross-platform": "npm run test:cross-platform:dev && npm run test:cross-platform:build",
+		"test:cross-platform:dev": "node test/setup.js && rimraf test/errors.json && cross-env DEV=true playwright test test/cross-platform/",
+		"test:cross-platform:build": "node test/setup.js && rimraf test/errors.json && playwright test test/cross-platform/"
 	},
 	"devDependencies": {
 		"@sveltejs/kit": "workspace:^",

packages/kit/test/apps/basics/test/cross-browser/client.test.js renamed to packages/kit/test/apps/basics/test/cross-platform/client.test.js

@@ -1016,7 +1016,7 @@ test.describe('Actions', () => {
 test.describe.serial('Cookies API', () => {
 	// there's a problem running these tests in the CI with webkit,
 	// since AFAICT the browser is using http://localhost and webkit won't
-	// set a `Secure` cookie on that. So we don't run these cross-browser
+	// set a `Secure` cookie on that. So we don't run these cross-platform
 
 	test('sanity check for cookies', async ({ page }) => {
 		await page.goto('/cookies');

packages/kit/test/apps/basics/test/cross-browser/test.js renamed to packages/kit/test/apps/basics/test/cross-platform/test.js

@@ -3,7 +3,8 @@
 	"private": true,
 	"version": "0.0.0-next.0",
 	"scripts": {
-		"test": "uvu . \"(spec\\.js|test[\\\\/]index\\.js)\""
+		"test": "uvu . \"(spec\\.js|test[\\\\/]index\\.js)\"",
+		"test:cross-platform": "uvu . \"(spec\\.js|test[\\\\/]index\\.js)\""
 	},
 	"type": "module",
 	"devDependencies": {

packages/kit/test/apps/basics/test/test.js

@@ -7,7 +7,8 @@
 		"build": "vite build",
 		"preview": "vite preview",
 		"check": "svelte-kit sync && tsc && svelte-check",
-		"test": "svelte-kit sync && pnpm build && uvu test"
+		"test": "svelte-kit sync && pnpm build && uvu test",
+		"test:cross-platform": "pnpm test"
 	},
 	"devDependencies": {
 		"@sveltejs/kit": "workspace:^",

packages/kit/test/build-errors/package.json

@@ -49,7 +49,7 @@
 			"outputMode": "new-only",
 			"env": ["CI", "TURBO_CACHE_KEY"]
 		},
-		"test:cross-browser": {
+		"test:cross-platform": {
 			"inputs": ["src/**", "scripts/**", "shared/**", "templates/**", "test/**"],
 			"outputs": ["coverage/", "test-results/**"],
 			"outputMode": "new-only",