Skip to content

Commit 197e01f

Browse files
authored
Revert "fix: build service workers in IIFE format" (#11400)
* Revert "fix: build service workers in IIFE format (#11129)" This reverts commit 5f052a3. * better fix * changeset * remove format --------- Co-authored-by: Rich Harris <[email protected]>
1 parent f8e3d8b commit 197e01f

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

.changeset/green-cycles-shake.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@sveltejs/kit': patch
3+
---
4+
5+
fix: prevent esbuild adding phantom exports to service worker

.changeset/tricky-meals-perform.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

packages/kit/src/exports/vite/build/build_service_worker.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,8 @@ export async function build_service_worker(
7070
'service-worker': service_worker_entry_file
7171
},
7272
output: {
73-
// default 'es' format would be nicer
74-
// iife is workaround for https://github.com/vitejs/vite/issues/15379
75-
format: 'iife',
76-
entryFileNames: '[name].js',
73+
// .mjs so that esbuild doesn't incorrectly inject `export` https://github.com/vitejs/vite/issues/15379
74+
entryFileNames: 'service-worker.mjs',
7775
assetFileNames: `${kit.appDir}/immutable/assets/[name].[hash][extname]`,
7876
inlineDynamicImports: true
7977
}
@@ -95,4 +93,7 @@ export async function build_service_worker(
9593
}
9694
}
9795
});
96+
97+
// rename .mjs to .js to avoid incorrect MIME types with ancient webservers
98+
fs.renameSync(`${out}/client/service-worker.mjs`, `${out}/client/service-worker.js`);
9899
}

0 commit comments

Comments
 (0)